Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AudioRecord JNI: fix mem leak on audio_attributes_t

Browse Source 
Free memory calloc'd to hold audio_attributes_t for the
  AudioRecord instance.

Bug: 109700675
Test: see bug
Change-Id: I688c6d2ee4a2db5a4d96b54e33bcc7237daef235
This commit is contained in:
Jean-Michel Trivi
2018-06-05 12:01:35 -07:00
parent 9a184cb7f3
commit 4ce27b51ea
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/jni/android_media_AudioRecord.cpp
View File

@@ -368,10 +368,19 @@ android_media_AudioRecord_setup(JNIEnv *env, jobject thiz, jobject weak_this,
// of the Java object (in mNativeCallbackCookie) so we can free the memory in finalize()
env->SetLongField(thiz, javaAudioRecordFields.nativeCallbackCookie, (jlong)lpCallbackData);
if (paa != NULL) {
// audio attributes were copied in AudioRecord creation
free(paa);
paa = NULL;
}
return (jint) AUDIO_JAVA_SUCCESS;
// failure:
native_init_failure:
if (paa != NULL) {
free(paa);
}
env->DeleteGlobalRef(lpCallbackData->audioRecord_class);
env->DeleteGlobalRef(lpCallbackData->audioRecord_ref);
delete lpCallbackData;