Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix incorrect RemoteInput result source

Browse Source 
Conditional was accidentally flipped in a previous change. This change
also de-dupes the problematic code.

Test: atest RemoteInputViewTest
Fixes: 224824265
Change-Id: I75fc4b77ea76b9166df0ef4f54a27d0381ba492a
This commit is contained in:
Steve Elliott
2022-03-15 16:19:39 -04:00
parent 0ede4b88ff
commit 4c1d687b1c
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
packages/SystemUI/src/com/android/systemui/statusbar/policy/RemoteInputViewController.kt
View File

@@ -299,10 +299,7 @@ class RemoteInputViewControllerImpl @Inject constructor(
view.clearAttachment()
entry.remoteInputUri = null
entry.remoteInputMimeType = null
val resultSource = entry.editedSuggestionInfo
?.let { RemoteInput.SOURCE_FREE_FORM_INPUT }
?: RemoteInput.SOURCE_CHOICE
RemoteInput.setResultsSource(fillInIntent, resultSource)
RemoteInput.setResultsSource(fillInIntent, remoteInputResultsSource)
return fillInIntent
}
@@ -332,10 +329,12 @@ class RemoteInputViewControllerImpl @Inject constructor(
entry.remoteInputText = fullText
// mirror prepareRemoteInputFromText for text input
val resultSource = entry.editedSuggestionInfo
?.let { RemoteInput.SOURCE_FREE_FORM_INPUT }
?: RemoteInput.SOURCE_CHOICE
RemoteInput.setResultsSource(fillInIntent, resultSource)
RemoteInput.setResultsSource(fillInIntent, remoteInputResultsSource)
return fillInIntent
}
private val remoteInputResultsSource
get() = entry.editedSuggestionInfo
?.let { RemoteInput.SOURCE_CHOICE }
?: RemoteInput.SOURCE_FREE_FORM_INPUT
}