Toast: Solve the NPE problem in session.java

In the if statement here, 'isFillDialogUiEnabled' should not be an
independent '||' operation, which will cause the previous addition to be
invalid. It should be in the same level as 'isViewFocusedLocked', and
use 'isRequestSupportFillDialog' replace.

Bug: 267986308

Test: Manual

Signed-off-by: hupeng3 <hp121520@gmail.com>
Change-Id: I8adc5eb7f24f2189e22b469f7c677bb2206cf3c8
This commit is contained in:
hupeng3
2023-02-06 14:53:32 +08:00
committed by Hu Peng
parent 52cdf7372d
commit 4a9fc440b8

View File

@@ -3840,8 +3840,7 @@ final class Session implements RemoteFillService.FillServiceCallbacks, ViewState
&& (mSessionFlags.mAugmentedAutofillOnly
|| !mSessionFlags.mInlineSupportedByService
|| mSessionFlags.mExpiredResponse)
&& isViewFocusedLocked(flags)
|| isFillDialogUiEnabled()) {
&& (isViewFocusedLocked(flags) || isRequestSupportFillDialog(flags))) {
if (sDebug) Slog.d(TAG, "Create inline request for augmented autofill");
remoteRenderService.getInlineSuggestionsRendererInfo(new RemoteCallback(
(extras) -> {