Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Statsd logging: Fix UiEvent logging instance IDs.

Browse Source 
Add the instance ID field to statsd UiEventReported calls that lacked
it, because all statsd writes should write all fields.

Fixes: 168760953
Test: atest NotificationManagerServiceTest
Change-Id: I8a6fb7a9e52c2fd818e2b92c62ea5902583b6f9f
This commit is contained in:
Will Brockman
2020-09-22 14:54:53 -04:00
parent a28729b629
commit 4a46eaf3dd
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
core/java/com/android/internal/logging/UiEventLoggerImpl.java
View File

@@ -33,7 +33,11 @@ public class UiEventLoggerImpl implements UiEventLogger {
public void log(UiEventEnum event, int uid, String packageName) {
final int eventID = event.getId();
if (eventID > 0) {
FrameworkStatsLog.write(FrameworkStatsLog.UI_EVENT_REPORTED, eventID, uid, packageName);
FrameworkStatsLog.write(FrameworkStatsLog.UI_EVENT_REPORTED,
/* event_id = 1 */ eventID,
/* uid = 2 */ uid,
/* package_name = 3 */ packageName,
/* instance_id = 4 */ 0);
}
}
@@ -42,8 +46,11 @@ public class UiEventLoggerImpl implements UiEventLogger {
InstanceId instance) {
final int eventID = event.getId();
if ((eventID > 0) && (instance != null)) {
FrameworkStatsLog.write(FrameworkStatsLog.UI_EVENT_REPORTED, eventID, uid, packageName,
instance.getId());
FrameworkStatsLog.write(FrameworkStatsLog.UI_EVENT_REPORTED,
/* event_id = 1 */ eventID,
/* uid = 2 */ uid,
/* package_name = 3 */ packageName,
/* instance_id = 4 */ instance.getId());
} else {
log(event, uid, packageName);
}