Merge "Use new PackageMonitor#register() without externalStorage parameter" into main

This commit is contained in:
Joanne Chung
2023-07-07 01:18:02 +00:00
committed by Android (Google) Code Review
2 changed files with 4 additions and 7 deletions

View File

@@ -95,7 +95,7 @@ public abstract class PackageMonitor extends android.content.BroadcastReceiver {
@UnsupportedAppUsage
public void register(Context context, Looper thread, UserHandle user,
boolean externalStorage) {
register(context, user, externalStorage,
register(context, user,
(thread == null) ? BackgroundThread.getHandler() : new Handler(thread));
}

View File

@@ -63,23 +63,20 @@ public class PackageMonitorTest {
public void testPackageMonitorMultipleRegisterThrowsException() throws Exception {
PackageMonitor spyPackageMonitor = spy(new TestPackageMonitor());
spyPackageMonitor.register(mMockContext, UserHandle.ALL, false /* externalStorage */,
mMockHandler);
spyPackageMonitor.register(mMockContext, UserHandle.ALL, mMockHandler);
assertThat(spyPackageMonitor.getRegisteredHandler()).isEqualTo(mMockHandler);
verify(mMockContext, times(2)).registerReceiverAsUser(any(), eq(UserHandle.ALL), any(),
eq(null), eq(mMockHandler));
assertThrows(IllegalStateException.class,
() -> spyPackageMonitor.register(mMockContext, UserHandle.ALL,
false /* externalStorage */, mMockHandler));
() -> spyPackageMonitor.register(mMockContext, UserHandle.ALL, mMockHandler));
}
@Test
public void testPackageMonitorRegisterMultipleUnRegisterThrowsException() throws Exception {
PackageMonitor spyPackageMonitor = spy(new TestPackageMonitor());
spyPackageMonitor.register(mMockContext, UserHandle.ALL, false /* externalStorage */,
mMockHandler);
spyPackageMonitor.register(mMockContext, UserHandle.ALL, mMockHandler);
spyPackageMonitor.unregister();
assertThrows(IllegalStateException.class, spyPackageMonitor::unregister);