[CredManUi] Do not truncate password values.

Also a few other minor fixes:
- Typos identified from previous changes.
- Remove the divider before the action chips

Bug: 269365202
Test: manual (see bug for screenshots)
Change-Id: I4a2117738cec904272ee4a938ee6f056c04babc9
This commit is contained in:
Helen Qin
2023-03-07 03:28:09 +00:00
parent 5b1b82c3f2
commit 48f4a730f6
3 changed files with 9 additions and 11 deletions

View File

@@ -44,7 +44,7 @@ data class UiState(
val selectedEntry: BaseEntry? = null,
val providerActivityState: ProviderActivityState = ProviderActivityState.NOT_APPLICABLE,
val dialogState: DialogState = DialogState.ACTIVE,
// True if the UI has one and onely one auto selectable entry. Its provider activiey will be
// True if the UI has one and only one auto selectable entry. Its provider activity will be
// launched immediately, and canceling it will cancel the whole UI flow.
val isAutoSelectFlow: Boolean = false,
)

View File

@@ -102,8 +102,9 @@ fun Entry(
SmallTitleText(text = entryHeadlineText, enforceOneLine = enforceOneLine)
if (passwordValue != null) {
Row(
modifier = Modifier.fillMaxWidth(),
modifier = Modifier.fillMaxWidth().padding(top = 4.dp),
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.Start,
) {
val visualTransformation = remember { PasswordVisualTransformation() }
val originalPassword by remember {
@@ -117,9 +118,13 @@ fun Entry(
)
}
BodySmallText(
text = displayedPassword.value, enforceOneLine = enforceOneLine)
text = displayedPassword.value,
// Apply weight to allow visibility button to render first so that
// it doesn't get squeezed out by a super long password.
modifier = Modifier.wrapContentSize().weight(1f, fill = false),
)
ToggleVisibilityButton(
modifier = Modifier.padding(start = 12.dp, top = 5.dp).size(24.dp),
modifier = Modifier.padding(start = 12.dp).size(24.dp),
onToggle = {
if (it) {
displayedPassword.value = originalPassword

View File

@@ -295,13 +295,6 @@ fun AllSignInOptionCard(
)
}
}
item {
Divider(
thickness = 1.dp,
color = Color.LightGray,
modifier = Modifier.padding(top = 16.dp)
)
}
// Manage sign-ins (action chips)
item {
ActionChips(