Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't send <Report ARC Initiated> until ARC is enabled

Browse Source 
Send <Report ARC Initiated> only when ARC is physically enabled.
Currently, this can be sent several seconds early, which violates the
CEC spec.

Currently, when initiating ARC, we do the following in parallel:
1. Query SADs -> Enable ARC
2. Send <Report ARC Initiated>

This CL queries SADs first, to better align the other two tasks:
Query SADs -> | 1. Enable ARC
              | 2. Send <Report ARC Initiated>

Bug: 232241939
Test: manual; atest HdmiCecLocalDeviceTvTest

Change-Id: Ifebc283a8143a7bb48e4cf14ef09090eb1f852fa
This commit is contained in:
Yan Han
2022-05-12 15:14:37 +02:00
committed by Nathalie Le Clair
parent 46887f8e68
commit 48b98602b2
5 changed files with 64 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
services/core/java/com/android/server/hdmi/HdmiCecLocalDeviceTv.java
View File

@@ -810,35 +810,24 @@ final class HdmiCecLocalDeviceTv extends HdmiCecLocalDevice {
}
}
/**
* Change ARC status into the given {@code enabled} status.
*
* @return {@code true} if ARC was in "Enabled" status
*/
@ServiceThreadOnly
boolean setArcStatus(boolean enabled) {
void enableArc(List<byte[]> supportedSads) {
assertRunOnServiceThread();
HdmiLogger.debug("Set Arc Status[old:%b new:true]", mArcEstablished);
HdmiLogger.debug("Set Arc Status[old:%b new:%b]", mArcEstablished, enabled);
boolean oldStatus = mArcEstablished;
if (enabled) {
RequestSadAction action = new RequestSadAction(
this, Constants.ADDR_AUDIO_SYSTEM,
new RequestSadAction.RequestSadCallback() {
@Override
public void onRequestSadDone(List<byte[]> supportedSads) {
enableAudioReturnChannel(enabled);
notifyArcStatusToAudioService(enabled, supportedSads);
mArcEstablished = enabled;
}
});
addAndStartAction(action);
} else {
enableAudioReturnChannel(enabled);
notifyArcStatusToAudioService(enabled, new ArrayList<>());
mArcEstablished = enabled;
}
return oldStatus;
enableAudioReturnChannel(true);
notifyArcStatusToAudioService(true, supportedSads);
mArcEstablished = true;
}
@ServiceThreadOnly
void disableArc() {
assertRunOnServiceThread();
HdmiLogger.debug("Set Arc Status[old:%b new:false]", mArcEstablished);
enableAudioReturnChannel(false);
notifyArcStatusToAudioService(false, new ArrayList<>());
mArcEstablished = false;
}
/**
@@ -1066,7 +1055,7 @@ final class HdmiCecLocalDeviceTv extends HdmiCecLocalDevice {
protected int handleTerminateArc(HdmiCecMessage message) {
assertRunOnServiceThread();
if (mService .isPowerStandbyOrTransient()) {
setArcStatus(false);
disableArc();
return Constants.HANDLED;
}
// Do not check ARC configuration since the AVR might have been already removed.
@@ -1353,7 +1342,7 @@ final class HdmiCecLocalDeviceTv extends HdmiCecLocalDevice {
if (avr == null) {
return;
}
setArcStatus(false);
disableArc();
// Seq #44.
removeAllRunningArcAction();

2
services/core/java/com/android/server/hdmi/RequestArcAction.java
View File

@@ -63,7 +63,7 @@ abstract class RequestArcAction extends HdmiCecFeatureAction {
finish();
return true;
} else if (originalOpcode == Constants.MESSAGE_REQUEST_ARC_INITIATION) {
tv().setArcStatus(false);
tv().disableArc();
finish();
return true;
}

2
services/core/java/com/android/server/hdmi/RequestArcInitiationAction.java
View File

@@ -48,7 +48,7 @@ final class RequestArcInitiationAction extends RequestArcAction {
public void onSendCompleted(int error) {
if (error != SendMessageResult.SUCCESS) {
// Turn off ARC status if <Request ARC Initiation> fails.
tv().setArcStatus(false);
tv().disableArc();
finish();
}
}

58
services/core/java/com/android/server/hdmi/SetArcTransmissionStateAction.java
View File

@@ -20,6 +20,8 @@ import android.hardware.hdmi.HdmiDeviceInfo;
import android.hardware.tv.cec.V1_0.SendMessageResult;
import android.util.Slog;
import java.util.List;
/**
* Feature action that handles enabling/disabling of ARC transmission channel.
* Once TV gets &lt;Initiate ARC&gt;, TV sends &lt;Report ARC Initiated&gt; to AV Receiver.
@@ -55,21 +57,31 @@ final class SetArcTransmissionStateAction extends HdmiCecFeatureAction {
boolean start() {
// Seq #37.
if (mEnabled) {
// Enable ARC status immediately before sending <Report Arc Initiated>.
// If AVR responds with <Feature Abort>, disable ARC status again.
// This is different from spec that says that turns ARC status to
// "Enabled" if <Report ARC Initiated> is acknowledged and no
// <Feature Abort> is received.
// But implemented this way to save the time having to wait for
// <Feature Abort>.
setArcStatus(true);
// If succeeds to send <Report ARC Initiated>, wait general timeout
// to check whether there is no <Feature Abort> for <Report ARC Initiated>.
mState = STATE_WAITING_TIMEOUT;
addTimer(mState, HdmiConfig.TIMEOUT_MS);
sendReportArcInitiated();
// Request SADs before enabling ARC
RequestSadAction action = new RequestSadAction(
localDevice(), Constants.ADDR_AUDIO_SYSTEM,
new RequestSadAction.RequestSadCallback() {
@Override
public void onRequestSadDone(List<byte[]> supportedSads) {
// Enable ARC status immediately before sending <Report Arc Initiated>.
// If AVR responds with <Feature Abort>, disable ARC status again.
// This is different from spec that says that turns ARC status to
// "Enabled" if <Report ARC Initiated> is acknowledged and no
// <Feature Abort> is received.
// But implemented this way to save the time having to wait for
// <Feature Abort>.
Slog.i(TAG, "Enabling ARC");
tv().enableArc(supportedSads);
// If succeeds to send <Report ARC Initiated>, wait general timeout to
// check whether there is no <Feature Abort> for <Report ARC Initiated>.
mState = STATE_WAITING_TIMEOUT;
addTimer(mState, HdmiConfig.TIMEOUT_MS);
sendReportArcInitiated();
}
});
addAndStartAction(action);
} else {
setArcStatus(false);
disableArc();
finish();
}
return true;
@@ -92,7 +104,7 @@ final class SetArcTransmissionStateAction extends HdmiCecFeatureAction {
case SendMessageResult.NACK:
// If <Report ARC Initiated> is negatively ack'ed, disable ARC and
// send <Report ARC Terminated> directly.
setArcStatus(false);
disableArc();
HdmiLogger.debug("Failed to send <Report Arc Initiated>.");
finish();
break;
@@ -101,16 +113,12 @@ final class SetArcTransmissionStateAction extends HdmiCecFeatureAction {
});
}
private void setArcStatus(boolean enabled) {
tv().setArcStatus(enabled);
Slog.i(TAG, "Change arc status to " + enabled);
private void disableArc() {
Slog.i(TAG, "Disabling ARC");
// If enabled before and set to "disabled" and send <Report Arc Terminated> to
// av reciever.
if (!enabled) {
sendCommand(HdmiCecMessageBuilder.buildReportArcTerminated(getSourceAddress(),
mAvrAddress));
}
tv().disableArc();
sendCommand(HdmiCecMessageBuilder.buildReportArcTerminated(getSourceAddress(),
mAvrAddress));
}
@Override
@@ -124,7 +132,7 @@ final class SetArcTransmissionStateAction extends HdmiCecFeatureAction {
int originalOpcode = cmd.getParams()[0] & 0xFF;
if (originalOpcode == Constants.MESSAGE_REPORT_ARC_INITIATED) {
HdmiLogger.debug("Feature aborted for <Report Arc Initiated>");
setArcStatus(false);
disableArc();
finish();
return true;
}

13
services/tests/servicestests/src/com/android/server/hdmi/HdmiCecLocalDeviceTvTest.java
View File

@@ -560,8 +560,19 @@ public class HdmiCecLocalDeviceTvTest {
HdmiCecMessage reportArcInitiated = HdmiCecMessageBuilder.buildReportArcInitiated(
ADDR_TV,
ADDR_AUDIO_SYSTEM);
assertThat(mNativeWrapper.getResultMessages()).contains(reportArcInitiated);
// <Report ARC Initiated> should only be sent after SAD querying is done
assertThat(mNativeWrapper.getResultMessages()).doesNotContain(reportArcInitiated);
// Finish querying SADs
assertThat(mNativeWrapper.getResultMessages()).contains(SAD_QUERY);
mNativeWrapper.clearResultMessages();
mTestLooper.moveTimeForward(HdmiConfig.TIMEOUT_MS);
mTestLooper.dispatchAll();
assertThat(mNativeWrapper.getResultMessages()).contains(SAD_QUERY);
mTestLooper.moveTimeForward(HdmiConfig.TIMEOUT_MS);
mTestLooper.dispatchAll();
assertThat(mNativeWrapper.getResultMessages()).contains(reportArcInitiated);
}
@Test