Prevent crash in AccountManager after profile removal.

When user profile is removed AccountManagerService.purgeUserData may be
called after a delay. Until it happens other methods may try to access
database for a removed profile which causes a crash.

Bug: 281980345
Test: N/A
Merged-In: Idb9840a5b9f9fdc84516149066cbb2a945c083a7
Change-Id: Ia98887774e16a70b472c881dfe1b4b5bddabb8e8
This commit is contained in:
Dmitry Dementyev
2023-06-28 14:57:54 -07:00
parent 03626acc2d
commit 486de90adb

View File

@@ -67,6 +67,7 @@ import android.content.pm.Signature;
import android.content.pm.SigningDetails.CertCapabilities;
import android.content.pm.UserInfo;
import android.database.Cursor;
import android.database.sqlite.SQLiteCantOpenDatabaseException;
import android.database.sqlite.SQLiteFullException;
import android.database.sqlite.SQLiteStatement;
import android.os.Binder;
@@ -1383,7 +1384,13 @@ public class AccountManagerService
private void purgeOldGrants(UserAccounts accounts) {
synchronized (accounts.dbLock) {
synchronized (accounts.cacheLock) {
List<Integer> uids = accounts.accountsDb.findAllUidGrants();
List<Integer> uids;
try {
uids = accounts.accountsDb.findAllUidGrants();
} catch (SQLiteCantOpenDatabaseException e) {
Log.w(TAG, "Could not delete grants for user = " + accounts.userId);
return;
}
for (int uid : uids) {
final boolean packageExists = mPackageManager.getPackagesForUid(uid) != null;
if (packageExists) {
@@ -1409,7 +1416,13 @@ public class AccountManagerService
mPackageManager.getPackageUidAsUser(packageName, accounts.userId);
} catch (NameNotFoundException e) {
// package does not exist - remove visibility values
accounts.accountsDb.deleteAccountVisibilityForPackage(packageName);
try {
accounts.accountsDb.deleteAccountVisibilityForPackage(packageName);
} catch (SQLiteCantOpenDatabaseException sqlException) {
Log.w(TAG, "Could not delete account visibility for user = "
+ accounts.userId, sqlException);
continue;
}
synchronized (accounts.dbLock) {
synchronized (accounts.cacheLock) {
for (Account account : accounts.visibilityCache.keySet()) {