Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change order of arguments to traceAsync

Browse Source 
To be consistent with other logging APIs such as android.util.Log and
Trace.asyncTraceForTrackBegin, make the track name the first argument
and the method/section name the second argument.

Test: New track appearing in a perfetto trace
Bug: 289353932
Change-Id: Ib7c88c52397cac0ba229ea525f5d127af400bdc8
This commit is contained in:
Peter Kalauskas
2023-07-07 12:47:48 -07:00
parent d756cad817
commit 48407f5fa6
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/SystemUI/shared/src/com/android/systemui/util/TraceUtils.kt
View File

@@ -67,7 +67,7 @@ class TraceUtils {
* under a single track.
*/
inline fun <T> traceAsync(method: String, block: () -> T): T =
traceAsync(method, "AsyncTraces", block)
traceAsync("AsyncTraces", method, block)
/**
* Creates an async slice in a track with [trackName] while [block] runs.
@@ -76,7 +76,7 @@ class TraceUtils {
* [trackName] of the track. The track is one of the rows visible in a perfetto trace inside
* SystemUI process.
*/
inline fun <T> traceAsync(method: String, trackName: String, block: () -> T): T {
inline fun <T> traceAsync(trackName: String, method: String, block: () -> T): T {
val cookie = lastCookie.incrementAndGet()
Trace.asyncTraceForTrackBegin(Trace.TRACE_TAG_APP, trackName, method, cookie)
try {

2
packages/SystemUI/src/com/android/systemui/keyguard/domain/interactor/KeyguardQuickAffordanceInteractor.kt
View File

@@ -443,7 +443,7 @@ constructor(
}
private suspend fun isFeatureDisabledByDevicePolicy(): Boolean =
traceAsync("isFeatureDisabledByDevicePolicy", TAG) {
traceAsync(TAG, "isFeatureDisabledByDevicePolicy") {
withContext(backgroundDispatcher) {
devicePolicyManager.areKeyguardShortcutsDisabled(userId = userTracker.userId)
}