Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NetworkManagementService.java: fix error-prone warnings

Browse Source 
- Lock objects should be final
- Inner classes should be static if possible

Change-Id: Idca268e03ea1e9f80e64012d1e011dc8bca1d9a8
Merged-In: Idca268e03ea1e9f80e64012d1e011dc8bca1d9a8
Fix: 38446237
Test: Build
This commit is contained in:
Andrew Scull
2017-05-19 15:37:20 +01:00
parent a2663b0060
commit 45f533c1ad
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
services/core/java/com/android/server/NetworkManagementService.java
View File

@@ -149,7 +149,7 @@ public class NetworkManagementService extends INetworkManagementService.Stub
*/
public static final String PERMISSION_SYSTEM = "SYSTEM";
class NetdResponseCode {
static class NetdResponseCode {
/* Keep in sync with system/netd/server/ResponseCode.h */
public static final int InterfaceListResult = 110;
public static final int TetherInterfaceListResult = 111;
@@ -220,7 +220,7 @@ public class NetworkManagementService extends INetworkManagementService.Stub
private final NetworkStatsFactory mStatsFactory = new NetworkStatsFactory();
private Object mQuotaLock = new Object();
private final Object mQuotaLock = new Object();
/** Set of interfaces with active quotas. */
@GuardedBy("mQuotaLock")
@@ -265,7 +265,7 @@ public class NetworkManagementService extends INetworkManagementService.Stub
@GuardedBy("mQuotaLock")
private boolean mDataSaverMode;
private Object mIdleTimerLock = new Object();
private final Object mIdleTimerLock = new Object();
/** Set of interfaces with active idle timers. */
private static class IdleTimerParams {
public final int timeout;