Mark FrameMetricsObserver::notify() as pure virtual

Bug: http://b/116873221

If not, Clang assumes that the TU which defines this function will
contain the vtable for the class as well.  Since there's no out-of-line
definition of this funciton, no TU ends up with the vtable.

This causes a problem with coverage builds, which are built with -O0,
where calls don't get inlined, thereby requiring a definition of the
vtable.  For non -O0 builds, the vtable is not required since the
virtual calls get inlined/optimized-out.

Test: Build with and without -O0.
Change-Id: I60a5cefcd1c327f1e00785fedbb2163c682b33d1
This commit is contained in:
Pirama Arumuga Nainar
2019-02-07 13:24:24 -08:00
parent 21b38267fa
commit 459afe96d1

View File

@@ -23,7 +23,7 @@ namespace uirenderer {
class FrameMetricsObserver : public VirtualLightRefBase {
public:
virtual void notify(const int64_t* buffer);
virtual void notify(const int64_t* buffer) = 0;
};
}; // namespace uirenderer