Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix cross user package visibility leakage for canPackageQuery API

Browse Source 
Returns false if the target packages are not installed under the
calling user.

Bug: 229684723
Test: atest CrossUserPackageVisibilityTests
Change-Id: Ie76f85bef808c3fef366d334978d007691f43991
This commit is contained in:
Rhed Jao
2022-06-01 17:38:33 +08:00
parent 6e8d0f67ad
commit 44edc93760
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
services/core/java/com/android/server/pm/ComputerEngine.java
View File

@@ -5547,7 +5547,7 @@ public class ComputerEngine implements Computer {
final PackageStateInternal packageState =
getPackageStateInternal(component.getPackageName());
return packageState != null && !shouldFilterApplication(packageState, callingUid,
component, TYPE_UNKNOWN, userId);
component, TYPE_UNKNOWN, userId, true /* filterUninstall */);
}
@Override
@@ -5591,9 +5591,9 @@ public class ComputerEngine implements Computer {
boolean throwException = sourceSetting == null || targetSetting == null;
if (!throwException) {
final boolean filterSource =
shouldFilterApplication(sourceSetting, callingUid, userId);
shouldFilterApplicationIncludingUninstalled(sourceSetting, callingUid, userId);
final boolean filterTarget =
shouldFilterApplication(targetSetting, callingUid, userId);
shouldFilterApplicationIncludingUninstalled(targetSetting, callingUid, userId);
// The caller must have visibility of the both packages
throwException = filterSource || filterTarget;
}