Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Visit URIs in landscape/portrait custom remote views." into rvc-dev

Browse Source
This commit is contained in:
Ioana Alexandru
2023-05-08 08:44:40 +00:00
committed by Android (Google) Code Review
parent 2a509c82ba 43e1ae4e0d
commit 42635aa4d0
2 changed files with 70 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/java/android/widget/RemoteViews.java
View File

@@ -562,6 +562,12 @@ public class RemoteViews implements Parcelable, Filter {
mActions.get(i).visitUris(visitor);
}
}
if (mLandscape != null) {
mLandscape.visitUris(visitor);
}
if (mPortrait != null) {
mPortrait.visitUris(visitor);
}
}
private static void visitIconUri(Icon icon, @NonNull Consumer<Uri> visitor) {

64
core/tests/coretests/src/android/widget/RemoteViewsTest.java
View File

@@ -20,6 +20,10 @@ import static org.junit.Assert.assertArrayEquals;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import android.app.ActivityOptions;
import android.app.PendingIntent;
@@ -29,6 +33,8 @@ import android.content.Intent;
import android.graphics.Bitmap;
import android.graphics.drawable.BitmapDrawable;
import android.graphics.drawable.Drawable;
import android.graphics.drawable.Icon;
import android.net.Uri;
import android.os.AsyncTask;
import android.os.Binder;
import android.os.Parcel;
@@ -50,6 +56,7 @@ import org.junit.runner.RunWith;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.concurrent.CountDownLatch;
import java.util.function.Consumer;
/**
* Tests for RemoteViews.
@@ -499,4 +506,61 @@ public class RemoteViewsTest {
return null;
}
}
@Test
public void visitUris() {
RemoteViews views = new RemoteViews(mPackage, R.layout.remote_views_test);
final Uri imageUri = Uri.parse("content://media/image");
final Icon icon1 = Icon.createWithContentUri("content://media/icon1");
final Icon icon2 = Icon.createWithContentUri("content://media/icon2");
final Icon icon3 = Icon.createWithContentUri("content://media/icon3");
final Icon icon4 = Icon.createWithContentUri("content://media/icon4");
views.setImageViewUri(R.id.image, imageUri);
views.setTextViewCompoundDrawables(R.id.text, icon1, icon2, icon3, icon4);
Consumer<Uri> visitor = (Consumer<Uri>) spy(Consumer.class);
views.visitUris(visitor);
verify(visitor, times(1)).accept(eq(imageUri));
verify(visitor, times(1)).accept(eq(icon1.getUri()));
verify(visitor, times(1)).accept(eq(icon2.getUri()));
verify(visitor, times(1)).accept(eq(icon3.getUri()));
verify(visitor, times(1)).accept(eq(icon4.getUri()));
}
@Test
public void visitUris_separateOrientation() {
final RemoteViews landscape = new RemoteViews(mPackage, R.layout.remote_views_test);
final Uri imageUriL = Uri.parse("content://landscape/image");
final Icon icon1L = Icon.createWithContentUri("content://landscape/icon1");
final Icon icon2L = Icon.createWithContentUri("content://landscape/icon2");
final Icon icon3L = Icon.createWithContentUri("content://landscape/icon3");
final Icon icon4L = Icon.createWithContentUri("content://landscape/icon4");
landscape.setImageViewUri(R.id.image, imageUriL);
landscape.setTextViewCompoundDrawables(R.id.text, icon1L, icon2L, icon3L, icon4L);
final RemoteViews portrait = new RemoteViews(mPackage, 33);
final Uri imageUriP = Uri.parse("content://portrait/image");
final Icon icon1P = Icon.createWithContentUri("content://portrait/icon1");
final Icon icon2P = Icon.createWithContentUri("content://portrait/icon2");
final Icon icon3P = Icon.createWithContentUri("content://portrait/icon3");
final Icon icon4P = Icon.createWithContentUri("content://portrait/icon4");
portrait.setImageViewUri(R.id.image, imageUriP);
portrait.setTextViewCompoundDrawables(R.id.text, icon1P, icon2P, icon3P, icon4P);
RemoteViews views = new RemoteViews(landscape, portrait);
Consumer<Uri> visitor = (Consumer<Uri>) spy(Consumer.class);
views.visitUris(visitor);
verify(visitor, times(1)).accept(eq(imageUriL));
verify(visitor, times(1)).accept(eq(icon1L.getUri()));
verify(visitor, times(1)).accept(eq(icon2L.getUri()));
verify(visitor, times(1)).accept(eq(icon3L.getUri()));
verify(visitor, times(1)).accept(eq(icon4L.getUri()));
verify(visitor, times(1)).accept(eq(imageUriP));
verify(visitor, times(1)).accept(eq(icon1P.getUri()));
verify(visitor, times(1)).accept(eq(icon2P.getUri()));
verify(visitor, times(1)).accept(eq(icon3P.getUri()));
verify(visitor, times(1)).accept(eq(icon4P.getUri()));
}
}