Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't rely on fallthrough in incident_section_gen

Browse Source 
Silences the following warning during build:

frameworks/base/tools/incident_section_gen/main.cpp:265:13:
    warning: unannotated fall-through between switch labels
[-Wimplicit-fallthrough]
            default:
            ^
frameworks/base/tools/incident_section_gen/main.cpp:265:13:
    note: insert 'GOOGLE_FALLTHROUGH_INTENDED;' to silence this warning
            default:
            ^
            GOOGLE_FALLTHROUGH_INTENDED;

frameworks/base/tools/incident_section_gen/main.cpp:265:13:
    note: insert 'break;' to avoid fall-through
            default:
            ^
            break;

Test: make -j50 2>&1 | grep incident_section
Change-Id: Ie59510025e59e96f0763726794ff19dae595c672
This commit is contained in:
Robin Lee
2018-11-29 14:38:30 +01:00
parent edc46f4239
commit 41773b73ea
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tools/incident_section_gen/main.cpp
View File

@@ -258,8 +258,9 @@ static bool isDefaultMessageImpl(const Descriptor* descriptor, const Destination
return false;
case FieldDescriptor::TYPE_STRING:
if (getPrivacyFlags(field).patterns_size() != 0) return false;
break;
default:
continue;
break;
}
}
parents->erase(descriptor->full_name());