Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve Bundle/PersistableBundle docs

Browse Source 
around equals(), hashCode(), toString()

Test: TH passes
Bug: 122589814
Bug: 62611412
Bug: 122589479
Change-Id: Ia644e437f9b5642228c2a7138b0518f73ef2996c
This commit is contained in:
Bernardo Rufino
2021-10-06 10:08:22 +01:00
parent 2885623021
commit 40e22dc991
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/java/android/os/Bundle.java
View File

@@ -33,6 +33,9 @@ import java.util.List;
/**
* A mapping from String keys to various {@link Parcelable} values.
*
* <p><b>Warning:</b> Note that {@link Bundle} is a lazy container and as such it does NOT implement
* {@link #equals(Object)} or {@link #hashCode()}.
*
* @see PersistableBundle
*/
public final class Bundle extends BaseBundle implements Cloneable, Parcelable {
@@ -1229,6 +1232,10 @@ public final class Bundle extends BaseBundle implements Cloneable, Parcelable {
maybePrefillHasFds();
}
/**
* Returns a string representation of the {@link Bundle} that may be suitable for debugging. It
* won't print the internal map if its content hasn't been unparcelled.
*/
@Override
public synchronized String toString() {
if (mParcelledData != null) {

9
core/java/android/os/PersistableBundle.java
View File

@@ -42,6 +42,9 @@ import java.util.ArrayList;
* supported by this class is purposefully restricted to simple objects that can
* safely be persisted to and restored from disk.
*
* <p><b>Warning:</b> Note that {@link PersistableBundle} is a lazy container and as such it does
* NOT implement {@link #equals(Object)} or {@link #hashCode()}.
*
* @see Bundle
*/
public final class PersistableBundle extends BaseBundle implements Cloneable, Parcelable,
@@ -310,8 +313,12 @@ public final class PersistableBundle extends BaseBundle implements Cloneable, Pa
return new PersistableBundle(); // An empty mutable PersistableBundle
}
/**
* Returns a string representation of the {@link PersistableBundle} that may be suitable for
* debugging. It won't print the internal map if its content hasn't been unparcelled.
*/
@Override
synchronized public String toString() {
public synchronized String toString() {
if (mParcelledData != null) {
if (isEmptyParcel()) {
return "PersistableBundle[EMPTY_PARCEL]";