Log less on negative deltas in kernel CPU time readers

Logging the second, third etc. negative delta detected for a single
UID increases logging without a clear debugging benefit vs. just
noting the UIDs with at least one negative delta.

Bug: 182272121
Change-Id: Ia7c6994203493467d07eeb8092da1679864dc89e
Signed-off-by: Connor O'Brien <connoro@google.com>
This commit is contained in:
Connor O'Brien
2021-05-06 16:39:58 -07:00
parent 3d46ae52dc
commit 3f8d333016

View File

@@ -477,18 +477,17 @@ public abstract class KernelCpuUidTimeReader<T> {
}
copyToCurTimes();
boolean notify = false;
boolean valid = true;
for (int i = 0; i < mFreqCount; i++) {
// Unit is 10ms.
mDeltaTimes[i] = mCurTimes[i] - lastTimes[i];
if (mDeltaTimes[i] < 0) {
Slog.e(mTag, "Negative delta from freq time for uid: " + uid
+ ", delta: " + mDeltaTimes[i]);
valid = false;
return;
}
notify |= mDeltaTimes[i] > 0;
}
if (notify && valid) {
if (notify) {
System.arraycopy(mCurTimes, 0, lastTimes, 0, mFreqCount);
if (cb != null) {
cb.onUidCpuTime(uid, mDeltaTimes);
@@ -826,11 +825,11 @@ public abstract class KernelCpuUidTimeReader<T> {
if (mDeltaTime[i] < 0) {
Slog.e(mTag, "Negative delta from cluster time for uid: " + uid
+ ", delta: " + mDeltaTime[i]);
valid = false;
return;
}
notify |= mDeltaTime[i] > 0;
}
if (notify && valid) {
if (notify) {
System.arraycopy(mCurTime, 0, lastTimes, 0, mNumClusters);
if (cb != null) {
cb.onUidCpuTime(uid, mDeltaTime);