Merge "Adding in verification of calling UID in onShellCommand"
This commit is contained in:
committed by
Android (Google) Code Review
commit
3ef59228f3
@@ -9681,6 +9681,10 @@ public class ActivityManagerService extends IActivityManager.Stub
|
||||
public void onShellCommand(FileDescriptor in, FileDescriptor out,
|
||||
FileDescriptor err, String[] args, ShellCallback callback,
|
||||
ResultReceiver resultReceiver) {
|
||||
final int callingUid = Binder.getCallingUid();
|
||||
if (callingUid != ROOT_UID && callingUid != Process.SHELL_UID) {
|
||||
throw new SecurityException("Shell commands are only callable by root or shell");
|
||||
}
|
||||
(new ActivityManagerShellCommand(this, false)).exec(
|
||||
this, in, out, err, args, callback, resultReceiver);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user