Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Moving BrightnessTracker dump outside of syncRoot lock

Browse Source 
Bug: b/261799432
Test: adb shell dumpsys display
Change-Id: I6eaece7f5a56fdce1c06487b9caee024ac3421ee
This commit is contained in:
Oleg Petsjonkin
2023-03-22 17:59:58 +00:00
parent c503984e94
commit 3d6d5f0185
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
services/core/java/com/android/server/display/DisplayManagerService.java
View File

@@ -2589,9 +2589,7 @@ public final class DisplayManagerService extends SystemService {
void setDisplayModeDirectorLoggingEnabled(boolean enabled) {
synchronized (mSyncRoot) {
if (mDisplayModeDirector != null) {
mDisplayModeDirector.setLoggingEnabled(enabled);
}
mDisplayModeDirector.setLoggingEnabled(enabled);
}
}
@@ -2852,8 +2850,11 @@ public final class DisplayManagerService extends SystemService {
private void dumpInternal(PrintWriter pw) {
pw.println("DISPLAY MANAGER (dumpsys display)");
BrightnessTracker brightnessTrackerLocal;
synchronized (mSyncRoot) {
brightnessTrackerLocal = mBrightnessTracker;
pw.println(" mSafeMode=" + mSafeMode);
pw.println(" mPendingTraversal=" + mPendingTraversal);
pw.println(" mViewports=" + mViewports);
@@ -2926,10 +2927,6 @@ public final class DisplayManagerService extends SystemService {
for (int i = 0; i < displayPowerControllerCount; i++) {
mDisplayPowerControllers.valueAt(i).dump(pw);
}
if (mBrightnessTracker != null) {
pw.println();
mBrightnessTracker.dump(pw);
}
pw.println();
mPersistentDataStore.dump(pw);
@@ -2942,6 +2939,10 @@ public final class DisplayManagerService extends SystemService {
mDisplayWindowPolicyControllers.valueAt(i).second.dump(" ", pw);
}
}
if (brightnessTrackerLocal != null) {
pw.println();
brightnessTrackerLocal.dump(pw);
}
pw.println();
mDisplayModeDirector.dump(pw);
mBrightnessSynchronizer.dump(pw);