Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix null exception on config change when ScreenDecoration is disabled

Browse Source 
Return early on callbacks
  - onConfigurationChanged()
  - onTuningChanged()

Bug: 169438063
Test: 1. disable ScreenDecorations:
         - adb shell setprop debug.disable_screen_decorations true
	 - adb shell pidof com.android.systemui |xargs -i adb shell kill -9 {}
      2. rotate device
Change-Id: Icadfdd0f10e252677392443f3280e5620d0fa797
This commit is contained in:
shawnlin
2020-10-15 20:32:29 +08:00
parent 7518e29196
commit 3d40072e87
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/SystemUI/src/com/android/systemui/ScreenDecorations.java
View File

@@ -582,6 +582,10 @@ public class ScreenDecorations extends SystemUI implements Tunable {
@Override
protected void onConfigurationChanged(Configuration newConfig) {
if (DEBUG_DISABLE_SCREEN_DECORATIONS) {
Log.i(TAG, "ScreenDecorations is disabled");
return;
}
mHandler.post(() -> {
int oldRotation = mRotation;
mPendingRotationChange = false;
@@ -766,6 +770,10 @@ public class ScreenDecorations extends SystemUI implements Tunable {
@Override
public void onTuningChanged(String key, String newValue) {
if (DEBUG_DISABLE_SCREEN_DECORATIONS) {
Log.i(TAG, "ScreenDecorations is disabled");
return;
}
mHandler.post(() -> {
if (mOverlays == null) return;
if (SIZE.equals(key)) {