Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Screen record UI polish

Browse Source 
- Fix capitalization
- Default to device audio
- Use showBigPictureWhenCollapsed instead of setting largeIcon
separately
- Update styles to inherit device default

Fixes: 185544094
Fixes: 185544175
Fixes: 186427367
Fixes: 185544265
Test: visual

Change-Id: Ic545f8bc0ef77aabaab24a4585c87c3aa29ac7f5
This commit is contained in:
Beth Thibodeau
2021-05-13 20:41:43 -04:00
parent 0c59d91acc
commit 3a6818bb99
4 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/SystemUI/res/values/strings.xml
View File

@@ -989,7 +989,7 @@
<string name="quick_settings_nfc_on">NFC is enabled</string>
<!-- QuickSettings: Screen record tile [CHAR LIMIT=NONE] -->
<string name="quick_settings_screen_record_label">Screen Record</string>
<string name="quick_settings_screen_record_label">Screen record</string>
<!-- QuickSettings: Text to prompt the user to begin a new recording [CHAR LIMIT=20] -->
<string name="quick_settings_screen_record_start">Start</string>
<!-- QuickSettings: Text to prompt the user to stop an ongoing recording [CHAR LIMIT=20] -->

3
packages/SystemUI/res/values/styles.xml
View File

@@ -682,7 +682,8 @@
</style>
<!-- Screen recording -->
<style name="ScreenRecord" parent="Theme.SystemUI.Dialog.GlobalActions">
<style name="ScreenRecord" parent="@android:style/Theme.DeviceDefault.DayNight">
<item name="android:windowNoTitle">true</item>
<item name="android:windowIsTranslucent">true</item>
<item name="android:windowBackground">@android:color/transparent</item>
<item name="android:windowIsFloating">true</item>

4
packages/SystemUI/src/com/android/systemui/screenrecord/RecordingService.java
View File

@@ -367,8 +367,8 @@ public class RecordingService extends Service implements MediaRecorder.OnInfoLis
if (thumbnailBitmap != null) {
Notification.BigPictureStyle pictureStyle = new Notification.BigPictureStyle()
.bigPicture(thumbnailBitmap)
.bigLargeIcon((Bitmap) null);
builder.setLargeIcon(thumbnailBitmap).setStyle(pictureStyle);
.showBigPictureWhenCollapsed(true);
builder.setStyle(pictureStyle);
}
return builder.build();
}

2
packages/SystemUI/src/com/android/systemui/screenrecord/ScreenRecordDialog.java
View File

@@ -90,8 +90,8 @@ public class ScreenRecordDialog extends Activity {
});
mModes = new ArrayList<>();
mModes.add(MIC);
mModes.add(INTERNAL);
mModes.add(MIC);
mModes.add(MIC_AND_INTERNAL);
mAudioSwitch = findViewById(R.id.screenrecord_audio_switch);