Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Detect duplicate addChecksums calls.

Browse Source 
Bug: 160605420
Test: atest ChecksumsTest
Change-Id: I1a56865b0b27845494a337bd1d8fb49ca346af2f
This commit is contained in:
Alex Buynytskyy
2020-11-16 17:55:35 -08:00
parent 152543056c
commit 373a01c3ad
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
core/java/android/content/pm/PackageInstaller.java
View File

@@ -1227,6 +1227,7 @@ public class PackageInstaller {
* {@link PackageManager#requestChecksums}.
* @throws SecurityException if called after the session has been
* committed or abandoned.
* @throws IllegalStateException if checksums for this file have already been added.
* @deprecated do not use installer-provided checksums,
* use platform-enforced checksums
* e.g. {@link Checksum#TYPE_WHOLE_MERKLE_ROOT_4K_SHA256}

12
services/core/java/com/android/server/pm/PackageInstallerSession.java
View File

@@ -991,12 +991,14 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub {
assertCallerIsOwnerOrRootLocked();
assertPreparedAndNotCommittedOrDestroyedLocked("addChecksums");
if (mChecksums.containsKey(name)) {
throw new IllegalStateException("Duplicate checksums.");
}
List<CertifiedChecksum> fileChecksums = new ArrayList<>();
mChecksums.put(name, fileChecksums);
for (Checksum checksum : checksums) {
List<CertifiedChecksum> fileChecksums = mChecksums.get(name);
if (fileChecksums == null) {
fileChecksums = new ArrayList<>();
mChecksums.put(name, fileChecksums);
}
fileChecksums.add(new CertifiedChecksum(checksum, initiatingPackageName,
mainCertificateBytes));
}