Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Attempt 2 for adding OWNERS for SNTP code

Browse Source 
Commit e5ad129716 combined with pending
reviews demonstrated the OWNERS syntax has quirks and it is not working
as intended.

Documentation used:
https://android-review.googlesource.com/plugins/code-owners/Documentation/backend-find-owners.html#syntax

The syntax guide recommends that patterns like sub-dir/* aren't used as
they can cause problems when renaming directories; better to have OWNERS
in the sub-dir. The pattern sntp/* didn't appear to be working (perhaps
because of spaces).

Test: None
Bug: 199481251
Change-Id: I193744eaaad529b9680d3ccf905b86d68f62f7ff
This commit is contained in:
Neil Fuller
2021-10-14 12:55:21 +01:00
parent e5ad129716
commit 3725e9c638
4 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/java/android/net/OWNERS
View File

@@ -2,5 +2,5 @@ set noparent
include platform/frameworks/base:/services/core/java/com/android/server/net/OWNERS
per-file SSL*, Uri*, Url* = prb@google.com, dauletz@google.com, narayan@google.com, ngeoffray@google.com
per-file SntpClient*, sntp/* = file:/services/core/java/com/android/server/timedetector/OWNERS
per-file SSL*,Uri*,Url* = prb@google.com,oth@google.com,narayan@google.com,ngeoffray@google.com
per-file SntpClient* = file:/services/core/java/com/android/server/timedetector/OWNERS

1
core/java/android/net/sntp/OWNERS Normal file
View File

@@ -0,0 +1 @@
include /services/core/java/com/android/server/timedetector/OWNERS

2
core/tests/coretests/src/android/net/OWNERS
View File

@@ -1 +1,3 @@
include /services/core/java/com/android/server/net/OWNERS
per-file SntpClient* = file:/services/core/java/com/android/server/timedetector/OWNERS

1
core/tests/coretests/src/android/net/sntp/OWNERS Normal file
View File

@@ -0,0 +1 @@
include /core/java/android/net/sntp/OWNERS