Merge "New Pipeline: Ensure finalize filter stage is not used unnecessarily."

This commit is contained in:
Jeff DeCew
2021-12-30 22:50:56 +00:00
committed by Android (Google) Code Review
3 changed files with 4 additions and 6 deletions

View File

@@ -82,11 +82,8 @@ public class BubbleCoordinator implements Coordinator {
public void attach(NotifPipeline pipeline) {
mNotifPipeline = pipeline;
mNotifPipeline.addNotificationDismissInterceptor(mDismissInterceptor);
mNotifPipeline.addFinalizeFilter(mNotifFilter);
if (mBubblesManagerOptional.isPresent()) {
mBubblesManagerOptional.get().addNotifCallback(mNotifCallback);
}
mNotifPipeline.addPreGroupFilter(mNotifFilter);
mBubblesManagerOptional.ifPresent(manager -> manager.addNotifCallback(mNotifCallback));
}
private final NotifFilter mNotifFilter = new NotifFilter(TAG) {

View File

@@ -90,6 +90,7 @@ public class KeyguardCoordinator implements Coordinator {
readShowSilentNotificationSetting();
setupInvalidateNotifListCallbacks();
// Filter at the "finalize" stage so that views remain bound by PreparationCoordinator
pipeline.addFinalizeFilter(mNotifFilter);
}

View File

@@ -49,6 +49,6 @@ public class MediaCoordinator implements Coordinator {
@Override
public void attach(NotifPipeline pipeline) {
pipeline.addFinalizeFilter(mMediaFilter);
pipeline.addPreGroupFilter(mMediaFilter);
}
}