Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Stop dispatching TYPE_VIEW_SELECTED a11y event on child ..."

Browse Source 
Revert submission 20920782-view-selected-parent-only

Reason for revert: Made another jank test worse somehow: http://b/265967298

Reverted changes: /q/submissionid:20920782-view-selected-parent-only

Change-Id: Iae4586e29c87a7b27a10ca639a0ac117b0f57cd8
This commit is contained in:
Daniel Norman
2023-01-26 00:32:10 +00:00
committed by Android (Google) Code Review
parent c8f21b0c3d
commit 34eba83330
2 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
core/java/android/view/View.java
View File

@@ -25780,10 +25780,6 @@ public class View implements Drawable.Callback, KeyEvent.Callback,
* @param selected true if the view must be selected, false otherwise
*/
public void setSelected(boolean selected) {
setSelected(selected, true);
}
void setSelected(boolean selected, boolean sendAccessibilityEvent) {
//noinspection DoubleNegation
if (((mPrivateFlags & PFLAG_SELECTED) != 0) != selected) {
mPrivateFlags = (mPrivateFlags & ~PFLAG_SELECTED) | (selected ? PFLAG_SELECTED : 0);
@@ -25791,13 +25787,11 @@ public class View implements Drawable.Callback, KeyEvent.Callback,
invalidate(true);
refreshDrawableState();
dispatchSetSelected(selected);
if (sendAccessibilityEvent) {
if (selected) {
sendAccessibilityEvent(AccessibilityEvent.TYPE_VIEW_SELECTED);
} else {
notifyViewAccessibilityStateChangedIfNeeded(
AccessibilityEvent.CONTENT_CHANGE_TYPE_UNDEFINED);
}
if (selected) {
sendAccessibilityEvent(AccessibilityEvent.TYPE_VIEW_SELECTED);
} else {
notifyViewAccessibilityStateChangedIfNeeded(
AccessibilityEvent.CONTENT_CHANGE_TYPE_UNDEFINED);
}
}
}

2
core/java/android/view/ViewGroup.java
View File

@@ -4629,7 +4629,7 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager
final View[] children = mChildren;
final int count = mChildrenCount;
for (int i = 0; i < count; i++) {
children[i].setSelected(selected, false);
children[i].setSelected(selected);
}
}