Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Uses main thread for ContentCaptureManager handler.

Browse Source 
Initially it was creating a new thread, which infers in a ~0.3ms cost in the
initial activity creation. Examples:

Before:
com.android.settings: 403.542us
com.google.android.apps.nexuslauncher: 13147.397us
android.contentcaptureservice.cts: 481.979us

After:
com.android.settings: 25.677us
com.google.android.apps.nexuslauncher: 45.0us
android.contentcaptureservice.cts: 56.041us

Test: manually System.out check above
Test: atest CtsContentCaptureServiceTestCases

Fixes: 121039624

Change-Id: I4e7d90c4556467612d8b914fb3d3a5bc05a852bd
This commit is contained in:
Felipe Leme
2019-01-17 13:42:35 -08:00
parent d46c3e2954
commit 34ccedf4a8
1 changed files with 7 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
core/java/android/view/contentcapture/ContentCaptureManager.java
View File

@@ -24,8 +24,8 @@ import android.annotation.UiThread;
import android.content.ComponentName;
import android.content.Context;
import android.os.Handler;
import android.os.HandlerThread;
import android.os.IBinder;
import android.os.Looper;
import android.os.RemoteException;
import android.util.Log;
@@ -51,8 +51,6 @@ public final class ContentCaptureManager {
private static final String TAG = ContentCaptureManager.class.getSimpleName();
private static final String BG_THREAD_NAME = "intel_svc_streamer_thread";
/**
* Timeout for calls to system_server.
*/
@@ -89,24 +87,13 @@ public final class ContentCaptureManager {
public ContentCaptureManager(@NonNull Context context,
@Nullable IContentCaptureManager service) {
mContext = Preconditions.checkNotNull(context, "context cannot be null");
if (VERBOSE) {
Log.v(TAG, "Constructor for " + context.getPackageName());
}
mService = service;
// TODO(b/119220549): use an existing bg thread instead...
final HandlerThread bgThread = new HandlerThread(BG_THREAD_NAME);
bgThread.start();
mHandler = Handler.createAsync(bgThread.getLooper());
}
if (VERBOSE) Log.v(TAG, "Constructor for " + context.getPackageName());
@NonNull
private static Handler newHandler() {
// TODO(b/119220549): use an existing bg thread instead...
// TODO(b/119220549): use UI Thread directly (as calls are one-way) or an existing bgThread
// or a shared thread / handler held at the Application level
final HandlerThread bgThread = new HandlerThread(BG_THREAD_NAME);
bgThread.start();
return Handler.createAsync(bgThread.getLooper());
mService = service;
// TODO(b/119220549): we might not even need a handler, as the IPCs are oneway. But if we
// do, then we should optimize it to run the tests after the Choreographer finishes the most
// important steps of the frame.
mHandler = Handler.createAsync(Looper.getMainLooper());
}
/**