Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow flags to be marked as overriden.

Browse Source 
Bug: 233906828
Test: manual
Change-Id: If8d8cf39683db32295c73946c37b4a6d33bf63a0
This commit is contained in:
Dave Mankoff
2022-05-04 19:51:52 +00:00
parent 5a9aeacc08
commit 3377987156
3 changed files with 66 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
packages/SystemUI/shared/src/com/android/systemui/flags/Flag.kt
View File

@@ -29,6 +29,7 @@ interface Flag<T> {
interface ParcelableFlag<T> : Flag<T>, Parcelable {
val default: T
val overridden: Boolean
override fun describeContents() = 0
}
@@ -46,7 +47,8 @@ interface SysPropFlag<T> : Flag<T> {
data class BooleanFlag @JvmOverloads constructor(
override val id: Int,
override val default: Boolean = false,
override val teamfood: Boolean = false
override val teamfood: Boolean = false,
override val overridden: Boolean = false
) : ParcelableFlag<Boolean> {
companion object {
@@ -59,12 +61,16 @@ data class BooleanFlag @JvmOverloads constructor(
private constructor(parcel: Parcel) : this(
id = parcel.readInt(),
default = parcel.readBoolean()
default = parcel.readBoolean(),
teamfood = parcel.readBoolean(),
overridden = parcel.readBoolean()
)
override fun writeToParcel(parcel: Parcel, flags: Int) {
parcel.writeInt(id)
parcel.writeBoolean(default)
parcel.writeBoolean(teamfood)
parcel.writeBoolean(overridden)
}
}
@@ -86,7 +92,8 @@ data class SysPropBooleanFlag @JvmOverloads constructor(
data class StringFlag @JvmOverloads constructor(
override val id: Int,
override val default: String = "",
override val teamfood: Boolean = false
override val teamfood: Boolean = false,
override val overridden: Boolean = false
) : ParcelableFlag<String> {
companion object {
@JvmField
@@ -116,7 +123,8 @@ data class ResourceStringFlag @JvmOverloads constructor(
data class IntFlag @JvmOverloads constructor(
override val id: Int,
override val default: Int = 0,
override val teamfood: Boolean = false
override val teamfood: Boolean = false,
override val overridden: Boolean = false
) : ParcelableFlag<Int> {
companion object {
@@ -147,7 +155,8 @@ data class ResourceIntFlag @JvmOverloads constructor(
data class LongFlag @JvmOverloads constructor(
override val id: Int,
override val default: Long = 0,
override val teamfood: Boolean = false
override val teamfood: Boolean = false,
override val overridden: Boolean = false
) : ParcelableFlag<Long> {
companion object {
@@ -172,7 +181,8 @@ data class LongFlag @JvmOverloads constructor(
data class FloatFlag @JvmOverloads constructor(
override val id: Int,
override val default: Float = 0f,
override val teamfood: Boolean = false
override val teamfood: Boolean = false,
override val overridden: Boolean = false
) : ParcelableFlag<Float> {
companion object {
@@ -203,7 +213,8 @@ data class ResourceFloatFlag @JvmOverloads constructor(
data class DoubleFlag @JvmOverloads constructor(
override val id: Int,
override val default: Double = 0.0,
override val teamfood: Boolean = false
override val teamfood: Boolean = false,
override val overridden: Boolean = false
) : ParcelableFlag<Double> {
companion object {
@@ -223,4 +234,4 @@ data class DoubleFlag @JvmOverloads constructor(
parcel.writeInt(id)
parcel.writeDouble(default)
}
}
}

44
packages/SystemUI/shared/src/com/android/systemui/flags/FlagManager.kt
View File

@@ -64,20 +64,29 @@ class FlagManager constructor(
intent.setPackage(RECEIVING_PACKAGE)
return CallbackToFutureAdapter.getFuture {
completer: CallbackToFutureAdapter.Completer<Collection<Flag<*>>> ->
context.sendOrderedBroadcast(intent, null,
object : BroadcastReceiver() {
override fun onReceive(context: Context, intent: Intent) {
val extras: Bundle? = getResultExtras(false)
val listOfFlags: java.util.ArrayList<ParcelableFlag<*>>? =
extras?.getParcelableArrayList(EXTRA_FLAGS)
if (listOfFlags != null) {
completer.set(listOfFlags)
} else {
completer.setException(NoFlagResultsException())
}
completer: CallbackToFutureAdapter.Completer<Collection<Flag<*>>> ->
context.sendOrderedBroadcast(
intent,
null,
object : BroadcastReceiver() {
override fun onReceive(context: Context, intent: Intent) {
val extras: Bundle? = getResultExtras(false)
val listOfFlags: java.util.ArrayList<ParcelableFlag<*>>? =
extras?.getParcelableArrayList(
EXTRA_FLAGS, ParcelableFlag::class.java
)
if (listOfFlags != null) {
completer.set(listOfFlags)
} else {
completer.setException(NoFlagResultsException())
}
}, null, Activity.RESULT_OK, "extra data", null)
}
},
null,
Activity.RESULT_OK,
"extra data",
null
)
"QueryingFlags"
}
}
@@ -152,7 +161,11 @@ class FlagManager constructor(
}
val parts = uri.pathSegments
val idStr = parts[parts.size - 1]
val id = try { idStr.toInt() } catch (e: NumberFormatException) { return }
val id = try {
idStr.toInt()
} catch (e: NumberFormatException) {
return
}
clearCacheAction?.accept(id)
dispatchListenersAndMaybeRestart(id, onSettingsChangedAction)
}
@@ -188,4 +201,5 @@ class FlagManager constructor(
}
class NoFlagResultsException : Exception(
"SystemUI failed to communicate its flags back successfully")
"SystemUI failed to communicate its flags back successfully"
)

22
packages/SystemUI/src/com/android/systemui/flags/FeatureFlagsDebug.java
View File

@@ -180,7 +180,7 @@ public class FeatureFlagsDebug implements FeatureFlags, Dumpable {
/** Specific override for Boolean flags that checks against the teamfood list.*/
private boolean readFlagValue(int id, boolean defaultValue) {
Boolean result = readFlagValueInternal(id, BooleanFlagSerializer.INSTANCE);
Boolean result = readBooleanFlagOverride(id);
// Only check for teamfood if the default is false.
if (!defaultValue && result == null && id != Flags.TEAMFOOD.getId()) {
if (mAllFlags.containsKey(id) && mAllFlags.get(id).getTeamfood()) {
@@ -191,6 +191,10 @@ public class FeatureFlagsDebug implements FeatureFlags, Dumpable {
return result == null ? defaultValue : result;
}
private Boolean readBooleanFlagOverride(int id) {
return readFlagValueInternal(id, BooleanFlagSerializer.INSTANCE);
}
@NonNull
private <T> T readFlagValue(int id, @NonNull T defaultValue, FlagSerializer<T> serializer) {
requireNonNull(defaultValue, "defaultValue");
@@ -388,16 +392,26 @@ public class FeatureFlagsDebug implements FeatureFlags, Dumpable {
@Nullable
private ParcelableFlag<?> toParcelableFlag(Flag<?> f) {
if (f instanceof BooleanFlag) {
return new BooleanFlag(f.getId(), isEnabled((BooleanFlag) f), f.getTeamfood());
return new BooleanFlag(
f.getId(),
isEnabled((BooleanFlag) f),
f.getTeamfood(),
readBooleanFlagOverride(f.getId()) != null);
}
if (f instanceof ResourceBooleanFlag) {
return new BooleanFlag(
f.getId(), isEnabled((ResourceBooleanFlag) f), f.getTeamfood());
f.getId(),
isEnabled((ResourceBooleanFlag) f),
f.getTeamfood(),
readBooleanFlagOverride(f.getId()) != null);
}
if (f instanceof SysPropBooleanFlag) {
// TODO(b/223379190): Teamfood not supported for sysprop flags yet.
return new BooleanFlag(
f.getId(), isEnabled((SysPropBooleanFlag) f), false);
f.getId(),
((SysPropBooleanFlag) f).getDefault(),
false,
!mSystemProperties.get(((SysPropBooleanFlag) f).getName()).isEmpty());
}
// TODO: add support for other flag types.