Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix ContentCaptureManagerTest test fail.

Browse Source 
The test uses constructor with null parameters, but the constructor
does not allow null parameters, NPE throws then test fail. Instead
of null parameters, we pass mock objects to prevent fail.

Bug: 140955671
Test: atest FrameworksCoreTests:android.view.contentcapture.\
ContentCaptureManagerTest

Change-Id: I9dfd91da078644cd334066e07e0e5e533166c4ed
This commit is contained in:
Joanne Chung
2020-03-24 14:53:37 +08:00
parent d5763c4c1d
commit 3015adf9c4
1 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
core/tests/coretests/src/android/view/contentcapture/ContentCaptureManagerTest.java
View File

@@ -15,11 +15,12 @@
*/
package android.view.contentcapture;
import static org.mockito.Mockito.mock;
import static org.testng.Assert.assertThrows;
import android.content.ContentCaptureOptions;
import android.content.Context;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mock;
@@ -37,16 +38,20 @@ public class ContentCaptureManagerTest {
@Mock
private Context mMockContext;
private ContentCaptureManager mManager;
@Before
public void before() {
mManager = new ContentCaptureManager(mMockContext, /* service= */ null,
/* options= */ null);
@Test
public void testConstructor_invalidParametersThrowsException() {
assertThrows(NullPointerException.class,
() -> new ContentCaptureManager(mMockContext, /* service= */ null, /* options= */
null));
}
@Test
public void testRemoveData_invalid() {
assertThrows(NullPointerException.class, () -> mManager.removeData(null));
public void testRemoveData_invalidParametersThrowsException() {
final IContentCaptureManager mockService = mock(IContentCaptureManager.class);
final ContentCaptureOptions options = new ContentCaptureOptions(null);
final ContentCaptureManager manager =
new ContentCaptureManager(mMockContext, mockService, options);
assertThrows(NullPointerException.class, () -> manager.removeData(null));
}
}