Merge "Revert "Revert "Update signature permissions when package signing is changed.""" into main

This commit is contained in:
Hai Zhang
2023-07-10 18:01:09 +00:00
committed by Android (Google) Code Review
2 changed files with 15 additions and 6 deletions

View File

@@ -867,10 +867,12 @@ public final class SigningDetails implements Parcelable {
return false;
}
// The capabilities for the past signing certs must match as well.
for (int i = 0; i < mPastSigningCertificates.length; i++) {
if (mPastSigningCertificates[i].getFlags()
!= that.mPastSigningCertificates[i].getFlags()) {
return false;
if (mPastSigningCertificates != null) {
for (int i = 0; i < mPastSigningCertificates.length; i++) {
if (mPastSigningCertificates[i].getFlags()
!= that.mPastSigningCertificates[i].getFlags()) {
return false;
}
}
}
return true;

View File

@@ -390,7 +390,14 @@ class AppIdPermissionPolicy : SchemePolicy() {
packageState: PackageState,
changedPermissionNames: MutableIndexedSet<String>
) {
packageState.androidPackage!!.permissions.forEachIndexed { _, parsedPermission ->
val androidPackage = packageState.androidPackage!!
// This may not be the same package as the old permission because the old permission owner
// can be different, hence using this somewhat strange name to prevent misuse.
val oldNewPackage = oldState.externalState.packageStates[packageState.packageName]
?.androidPackage
val isPackageSigningChanged = oldNewPackage != null &&
androidPackage.signingDetails != oldNewPackage.signingDetails
androidPackage.permissions.forEachIndexed { _, parsedPermission ->
val newPermissionInfo = PackageInfoUtils.generatePermissionInfo(
parsedPermission, PackageManager.GET_META_DATA.toLong()
)!!
@@ -520,7 +527,7 @@ class AppIdPermissionPolicy : SchemePolicy() {
newPackageName != oldPermission.packageName ||
newPermission.protectionLevel != oldPermission.protectionLevel || (
oldPermission.isReconciled && (
(
(newPermission.isSignature && isPackageSigningChanged) || (
newPermission.isKnownSigner &&
newPermission.knownCerts != oldPermission.knownCerts
) || (