Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove duplicated startInputUncheckedLocked invocation

Browse Source 
As CL[1] removed unused "debug.optimize_startinput" flag logic in
IMMS#startInputOrWindowGainedFocusInternalLocked, we can even remove
duplicated startInputUncheckedLocked invocation to simpfy the code
block of the input didn't start part.

Note that this CL is a mechanical code refactoring, it should not have
any behavior change.

[1]: Ie7b09f16e517c0550ac495a8a8c8ef20abb6938e

Bug: 171827834
Test: atest CtsInputMethodTestCases
Change-Id: I8fbb2c6ad4dfbd8388d1780375f53fd750ebd83e
This commit is contained in:
Ming-Shin Lu
2021-02-26 21:32:17 +08:00
parent 5f630223cc
commit 2d29a3ad85
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
View File

@@ -3647,12 +3647,9 @@ public class InputMethodManagerService extends IInputMethodManager.Stub
hideCurrentInputLocked(mCurFocusedWindow, 0, null,
SoftInputShowHideReason.HIDE_SAME_WINDOW_FOCUSED_WITHOUT_EDITOR);
}
res = startInputUncheckedLocked(cs, inputContext, missingMethods, attribute,
startInputFlags, startInputReason);
} else {
res = startInputUncheckedLocked(cs, inputContext, missingMethods, attribute,
startInputFlags, startInputReason);
}
res = startInputUncheckedLocked(cs, inputContext, missingMethods, attribute,
startInputFlags, startInputReason);
} else {
res = InputBindResult.NULL_EDITOR_INFO;
}