Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

shell pm: move context creation to where it's used

Browse Source 
If something went wrong with the shell package, it's useful for pm
commands to still work so that a developer is still able to put
things back the way they were.

Test: atest CtsNativeMediaAAudioTestCases --user-type secondary_user
Bug: 159157348
Change-Id: I9d3b4f8f93496a5df2055681bd88c61adc435408
This commit is contained in:
Robin Lee
2020-11-26 01:53:08 +01:00
parent ad44816045
commit 2cae9f6275
1 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
services/core/java/com/android/server/pm/PackageManagerShellCommand.java
View File

@@ -146,7 +146,7 @@ class PackageManagerShellCommand extends ShellCommand {
final IPackageManager mInterface;
final IPermissionManager mPermissionManager;
final Context mShellPackageContext;
final Context mContext;
final private WeakHashMap<String, Resources> mResourceCache =
new WeakHashMap<String, Resources>();
int mTargetUser;
@@ -158,13 +158,7 @@ class PackageManagerShellCommand extends ShellCommand {
PackageManagerService service, IPermissionManager permissionManager, Context context) {
mInterface = service;
mPermissionManager = permissionManager;
try {
mShellPackageContext = context.createPackageContextAsUser(
"com.android.shell", 0, Binder.getCallingUserHandle());
} catch (NameNotFoundException e) {
// should not happen
throw new RuntimeException(e);
}
mContext = context;
}
@Override
@@ -487,8 +481,17 @@ class PackageManagerShellCommand extends ShellCommand {
return 1;
}
final Context shellPackageContext;
try {
shellPackageContext = mContext.createPackageContextAsUser(
"com.android.shell", 0, Binder.getCallingUserHandle());
} catch (NameNotFoundException e) {
// should not happen
throw new RuntimeException(e);
}
final LocalIntentReceiver receiver = new LocalIntentReceiver();
RollbackManager rm = mShellPackageContext.getSystemService(RollbackManager.class);
RollbackManager rm = shellPackageContext.getSystemService(RollbackManager.class);
RollbackInfo rollback = null;
for (RollbackInfo r : rm.getAvailableRollbacks()) {
for (PackageRollbackInfo info : r.getPackages()) {