Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stop verifying fs-verity signature in kernel

Browse Source 
This has become redundant since we're now checking the signature in
userspace.

Bug: 258538225
Test: atest GtsFontHostTestCases
Test: atest UpdatableFontDirTest
Test: atest UpdatableSystemFontTest
Test: atest FontManagerTest
Change-Id: I18dc93e1b54b3ff97474113cd5689e7cc058e000
Merged-In: I18dc93e1b54b3ff97474113cd5689e7cc058e000
This commit is contained in:
Victor Hsieh
2022-11-10 16:17:59 -08:00
parent d163351b15
commit 2ada499332
3 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
services/core/java/com/android/server/graphics/fonts/FontManagerService.java
View File

@@ -186,8 +186,8 @@ public final class FontManagerService extends IFontManager.Stub {
}
@Override
public void setUpFsverity(String filePath, byte[] pkcs7Signature) throws IOException {
VerityUtils.setUpFsverity(filePath, pkcs7Signature);
public void setUpFsverity(String filePath) throws IOException {
VerityUtils.setUpFsverity(filePath, /* signature */ (byte[]) null);
}
@Override

5
services/core/java/com/android/server/graphics/fonts/UpdatableFontDir.java
View File

@@ -78,7 +78,7 @@ final class UpdatableFontDir {
interface FsverityUtil {
boolean isFromTrustedProvider(String path, byte[] pkcs7Signature);
void setUpFsverity(String path, byte[] pkcs7Signature) throws IOException;
void setUpFsverity(String path) throws IOException;
boolean rename(File src, File dest);
}
@@ -354,8 +354,7 @@ final class UpdatableFontDir {
try {
// Do not parse font file before setting up fs-verity.
// setUpFsverity throws IOException if failed.
mFsverityUtil.setUpFsverity(tempNewFontFile.getAbsolutePath(),
pkcs7Signature);
mFsverityUtil.setUpFsverity(tempNewFontFile.getAbsolutePath());
} catch (IOException e) {
throw new SystemFontException(
FontManager.RESULT_ERROR_VERIFICATION_FAILURE,

19
services/tests/servicestests/src/com/android/server/graphics/fonts/UpdatableFontDirTest.java
View File

@@ -109,17 +109,16 @@ public final class UpdatableFontDirTest {
@Override
public boolean isFromTrustedProvider(String path, byte[] signature) {
return mHasFsverityPaths.contains(path);
if (!mHasFsverityPaths.contains(path)) {
return false;
}
String fakeSignature = new String(signature, StandardCharsets.UTF_8);
return GOOD_SIGNATURE.equals(fakeSignature);
}
@Override
public void setUpFsverity(String path, byte[] pkcs7Signature) throws IOException {
String fakeSignature = new String(pkcs7Signature, StandardCharsets.UTF_8);
if (GOOD_SIGNATURE.equals(fakeSignature)) {
mHasFsverityPaths.add(path);
} else {
throw new IOException("Failed to set up fake fs-verity");
}
public void setUpFsverity(String path) throws IOException {
mHasFsverityPaths.add(path);
}
@Override
@@ -813,8 +812,8 @@ public final class UpdatableFontDirTest {
}
@Override
public void setUpFsverity(String path, byte[] pkcs7Signature) throws IOException {
mFakeFsverityUtil.setUpFsverity(path, pkcs7Signature);
public void setUpFsverity(String path) throws IOException {
mFakeFsverityUtil.setUpFsverity(path);
}
@Override