Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tweak SettingsTheme

Browse Source 
- Create SettingsPreferenceTheme to avoid resource conflicted in
  another source path.
- Follow UX suggestion to adjust listItemPaddingEnd

Bug: 184744354
Test: manual
Change-Id: I41abd2e8f830db3cd76307bf536d90d571af2be9
This commit is contained in:
Edgar Wang
2021-04-08 00:10:29 +08:00
parent 0d4e510467
commit 290c385062
3 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/SettingsLib/SettingsTheme/res/values-v31/dimens.xml
View File

@@ -19,7 +19,7 @@
<dimen name="preference_title_font_size">20sp</dimen>
<dimen name="icon_min_width">48dp</dimen>
<dimen name="preference_padding_start">24dp</dimen>
<dimen name="preference_padding_end">24dp</dimen>
<dimen name="preference_padding_end">16dp</dimen>
<dimen name="app_preference_padding_start">20dp</dimen>
<dimen name="app_icon_min_width">52dp</dimen>
</resources>

13
packages/SettingsLib/SettingsTheme/res/values/styles_preference.xml
View File

@@ -15,6 +15,7 @@
limitations under the License.
-->
<resources>
<!--DEPRECATED. It will remove after all of client team migrated to new style. -->
<style name="PreferenceTheme" parent="@style/PreferenceThemeOverlay">
<item name="preferenceCategoryStyle">@style/SettingsCategoryPreference</item>
<item name="preferenceStyle">@style/SettingsPreference</item>
@@ -27,6 +28,18 @@
<item name="footerPreferenceStyle">@style/Preference.Material</item>
</style>
<style name="SettingsPreferenceTheme" parent="@style/PreferenceThemeOverlay">
<item name="preferenceCategoryStyle">@style/SettingsCategoryPreference</item>
<item name="preferenceStyle">@style/SettingsPreference</item>
<item name="checkBoxPreferenceStyle">@style/SettingsCheckBoxPreference</item>
<item name="dialogPreferenceStyle">@style/SettingsPreference</item>
<item name="editTextPreferenceStyle">@style/SettingsEditTextPreference</item>
<item name="dropdownPreferenceStyle">@style/SettingsDropdownPreference</item>
<item name="switchPreferenceStyle">@style/SettingsSwitchPreference</item>
<item name="seekBarPreferenceStyle">@style/SettingsSeekbarPreference</item>
<item name="footerPreferenceStyle">@style/Preference.Material</item>
</style>
<style name="SettingsCategoryPreference" parent="@style/Preference.Category.Material">
<item name="iconSpaceReserved">@bool/config_icon_space_reserved</item>
<item name="allowDividerAbove">@bool/config_allow_divider</item>

2
packages/SettingsLib/SettingsTheme/res/values/themes.xml
View File

@@ -21,7 +21,7 @@
<item name="android:textAppearanceListItem">@style/TextAppearance.PreferenceTitle</item>
<item name="android:listPreferredItemPaddingStart">@dimen/preference_padding_start</item>
<item name="android:listPreferredItemPaddingEnd">@dimen/preference_padding_end</item>
<item name="preferenceTheme">@style/PreferenceTheme</item>
<item name="preferenceTheme">@style/SettingsPreferenceTheme</item>
</style>
<!-- Using in SubSettings page including injected settings page -->