Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't update routes if Dhcp fails.

Browse Source 
bug:8377625
Change-Id: I11d2c29728078813bfb1245cc46e8cce2b307a2c
This commit is contained in:
Robert Greenwalt
2013-03-15 10:48:46 -07:00
parent e78aa89647
commit 28cdf1dc22
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/java/android/net/DhcpStateMachine.java
View File

@@ -359,7 +359,7 @@ public class DhcpStateMachine extends StateMachine {
} else if (dhcpAction == DhcpAction.RENEW) {
if (DBG) Log.d(TAG, "DHCP renewal on " + mInterfaceName);
success = NetworkUtils.runDhcpRenew(mInterfaceName, dhcpResults);
dhcpResults.updateFromDhcpRequest(mDhcpResults);
if (success) dhcpResults.updateFromDhcpRequest(mDhcpResults);
}
if (success) {
if (DBG) Log.d(TAG, "DHCP succeeded on " + mInterfaceName);

4
core/jni/android_net_NetUtils.cpp
View File

@@ -136,6 +136,10 @@ static jboolean android_net_utils_runDhcpCommon(JNIEnv* env, jobject clazz, jstr
result = ::dhcp_do_request(nameStr, ipaddr, gateway, &prefixLength,
dns, server, &lease, vendorInfo, domains);
}
if (result != 0) {
ALOGD("dhcp_do_request failed");
}
env->ReleaseStringUTFChars(ifname, nameStr);
if (result == 0) {
env->CallVoidMethod(dhcpResults, dhcpResultsFieldIds.clear);