Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enforce package visibility filter rules to the isTrusted api

Browse Source 
The api leaks packages that hold media control permission or
notification listener enabled on the device. This cl uses package
visibility rules to filter the caller and the package name.

In normal cases, the package name passed to the api is the caller
itself or an app that binds to the caller's session service.
Both are legitimate to the package visibility rules. For caller
passing arbitrary package names to the api declares package
visibility in the manifest is necessary.

Bug: 238862819
Test: atest MediaSessionManagerHostTest
Test: atest MediaSessionManagerTest
Test: atest CtsAppEnumerationTestCases
Change-Id: I33579cb8203c8a9658372ba9ed12bb0cbb1155c6
This commit is contained in:
Rhed Jao
2022-12-06 15:43:24 +08:00
parent 90d4a5a5d7
commit 289e1b7813
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
services/core/java/com/android/server/media/MediaSessionService.java
View File

@@ -2046,6 +2046,11 @@ public class MediaSessionService extends SystemService implements Monitor {
int controllerUid) {
final int uid = Binder.getCallingUid();
final int userId = UserHandle.getUserHandleForUid(uid).getIdentifier();
if (LocalServices.getService(PackageManagerInternal.class)
.filterAppAccess(controllerPackageName, uid, userId)) {
// The controllerPackageName is not visible to the caller.
return false;
}
final long token = Binder.clearCallingIdentity();
try {
// Don't perform check between controllerPackageName and controllerUid.