Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a bug in sentence detection when input is too long.

Browse Source 
When the unchecked length of the current sentence is too long, the
spell checker should check the first MAX_SENTENCE_LGNTH characters of
the unchecked part. In this case, detectSentenceBOundary should return
[textChangesStart, textChangeStart + MAX_SENTENCE_LENGTH)

Fix: 188875278

Test: manual test
Change-Id: I31847aed2d564f7bc1ff43c83adae3bb7c99c0d1
This commit is contained in:
Qi Wang
2021-05-21 17:37:00 +08:00
parent 1d2868c45b
commit 2648035bda
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/java/android/widget/SpellChecker.java
View File

@@ -821,7 +821,7 @@ public class SpellChecker implements SpellCheckerSessionListener {
// The offset should be rounded up to word boundary.
int uncheckedLength = sentenceEnd - textChangeStart;
if (uncheckedLength > MAX_SENTENCE_LENGTH) {
sentenceEnd = findSeparator(sequence, sentenceStart + MAX_SENTENCE_LENGTH,
sentenceEnd = findSeparator(sequence, textChangeStart + MAX_SENTENCE_LENGTH,
sentenceEnd);
sentenceStart = roundUpToWordStart(sequence, textChangeStart, sentenceStart);
} else {
@@ -829,7 +829,7 @@ public class SpellChecker implements SpellCheckerSessionListener {
sentenceStart);
}
}
return new Range(sentenceStart, sentenceEnd);
return new Range<>(sentenceStart, Math.max(sentenceStart, sentenceEnd));
}
private int roundUpToWordStart(CharSequence sequence, int position, int frontBoundary) {