Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Do not enter pip during transient launch."

Browse Source 
This reverts commit 842e065311.

Reason for revert: b/291722322

Change-Id: Ib036c73cd1cf175d96f07335b260ce3678762091
This commit is contained in:
Sam Dubey
2023-07-18 11:25:56 +00:00
committed by Android (Google) Code Review
parent 842e065311
commit 23e3c17f36
2 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
services/core/java/com/android/server/wm/Task.java
View File

@@ -5251,18 +5251,17 @@ class Task extends TaskFragment {
// Ensure that we do not trigger entering PiP an activity on the root pinned task.
return;
}
final boolean isTransient = opts != null && opts.getTransientLaunch();
final Task targetRootTask = toFrontTask != null
? toFrontTask.getRootTask() : toFrontActivity.getRootTask();
final boolean isTransient = opts != null && opts.getTransientLaunch()
|| (targetRootTask != null
&& targetRootTask.mTransitionController.isTransientHide(targetRootTask));
if (targetRootTask != null && (targetRootTask.isActivityTypeAssistant() || isTransient)) {
// Ensure the task/activity being brought forward is not the assistant and is not
// transient. In the case of transient-launch, we want to wait until the end of the
// transition and only allow switch if the transient launch was committed.
return;
}
pipCandidate.supportsEnterPipOnTaskSwitch = true;
// Ensure the task/activity being brought forward is not the assistant and is not transient
// nor transient hide target. In the case of transient-launch, we want to wait until the end
// of the transition and only allow to enter pip on task switch after the transient launch
// was committed.
pipCandidate.supportsEnterPipOnTaskSwitch = targetRootTask == null
|| !(targetRootTask.isActivityTypeAssistant() || isTransient);
}
/**

4
services/core/java/com/android/server/wm/Transition.java
View File

@@ -1041,10 +1041,6 @@ class Transition implements BLASTSyncEngine.TransactionReadyListener {
ar.getTaskFragment().startPausing(false /* uiSleeping */,
null /* resuming */, "finishTransition");
} finally {
// Didn't schedule for pip, clear the supportsEnterPipOnTaskSwitch flag.
if (!ar.mPauseSchedulePendingForPip) {
ar.supportsEnterPipOnTaskSwitch = false;
}
mController.mAtm.mTaskSupervisor.mUserLeaving = false;
}
// Return false anyway because there's no guarantee that the app will enter pip.