Merge "Remove explicit toUpperCase after CountryDetector is fixed to return uppercase region code."

This commit is contained in:
David Brown
2011-07-01 13:19:37 -07:00
committed by Android (Google) Code Review
2 changed files with 0 additions and 13 deletions

View File

@@ -94,9 +94,6 @@ public class PhoneNumberFormattingTextWatcher implements TextWatcher {
*/
public PhoneNumberFormattingTextWatcher(String countryCode) {
if (countryCode == null) throw new IllegalArgumentException();
// TODO: remove this once CountryDetector.detectCountry().getCountryIso() is fixed to always
// return uppercase. Tracked at b/4941319.
countryCode = countryCode.toUpperCase(Locale.ENGLISH);
mFormatter = PhoneNumberUtil.getInstance().getAsYouTypeFormatter(countryCode);
}

View File

@@ -526,16 +526,6 @@ public class CallerInfo {
+ countryIso);
}
// Temp workaround: The current libphonenumber library requires
// the countryIso to be uppercase (e.g. "US") but the
// detector.detectCountry().getCountryIso() call currently returns
// "us". Passing "us" to util.parse() will just result in a
// NumberParseException.
// So force the countryIso to uppercase for now.
// TODO: remove this once getCountryIso() is fixed to always
// return uppercase.
countryIso = countryIso.toUpperCase();
PhoneNumber pn = null;
try {
if (VDBG) Log.v(TAG, "parsing '" + number