Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NotificationService causes watchdog issues and improves performance

Browse Source 
NotificationComparator will visit settings.db every time it compares ,
and indirectly calling IntArrayMemory is very time consuming, so the solution is optimized

Test: manual - atest NotificationManagerServiceTest and check the logs...

Bug:145560121

Change-Id: Ic66c87d65790b408846cb7ed7ab131c58482fe16
Signed-off-by: shaozhongqi <shaozhongqi@xiaomi.com>
This commit is contained in:
shaozhongqi
2019-12-03 17:43:20 +08:00
parent c83781809e
commit 202699b232
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
services/core/java/com/android/server/notification/NotificationComparator.java
View File

@@ -23,7 +23,6 @@ import android.content.BroadcastReceiver;
import android.content.Context;
import android.content.Intent;
import android.content.IntentFilter;
import android.provider.Settings;
import android.telecom.TelecomManager;
import com.android.internal.util.NotificationMessagingUtil;
@@ -55,14 +54,9 @@ public class NotificationComparator
final boolean isLeftHighImportance = leftImportance >= IMPORTANCE_DEFAULT;
final boolean isRightHighImportance = rightImportance >= IMPORTANCE_DEFAULT;
// With new interruption model, prefer importance bucket above all other criteria
// (to ensure buckets are contiguous)
if (Settings.Secure.getInt(mContext.getContentResolver(),
Settings.Secure.NOTIFICATION_NEW_INTERRUPTION_MODEL, 1) == 1) {
if (isLeftHighImportance != isRightHighImportance) {
// by importance bucket, high importance higher than low importance
return -1 * Boolean.compare(isLeftHighImportance, isRightHighImportance);
}
if (isLeftHighImportance != isRightHighImportance) {
// by importance bucket, high importance higher than low importance
return -1 * Boolean.compare(isLeftHighImportance, isRightHighImportance);
}
// first all colorized notifications