Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensure dumpable tag is unique

Browse Source 
By appending the current instance to its tag

Test: manual
Fixes: 183137150
Change-Id: I4734a18ea3d5f79c32653e70ebf9216c36594d9d
This commit is contained in:
Beverly
2021-03-19 08:20:31 -04:00
parent b4a4b46b7b
commit 1faa1baaa6
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/SystemUI/src/com/android/systemui/biometrics/UdfpsAnimationViewController.java
View File

@@ -72,7 +72,7 @@ abstract class UdfpsAnimationViewController<T extends UdfpsAnimationView>
mStateListener.onStateChanged(mStatusBarStateController.getState());
mStatusBar.addExpansionChangedListener(mStatusBarExpansionChangedListener);
mDumpManger.registerDumpable(getTag(), this);
mDumpManger.registerDumpable(getDumpTag(), this);
}
@Override
@@ -80,7 +80,17 @@ abstract class UdfpsAnimationViewController<T extends UdfpsAnimationView>
mStatusBarStateController.removeCallback(mStateListener);
mStatusBar.removeExpansionChangedListener(mStatusBarExpansionChangedListener);
mDumpManger.unregisterDumpable(getTag());
mDumpManger.unregisterDumpable(getDumpTag());
}
/**
* in some cases, onViewAttached is called for the newly added view using an instance of
* this controller before onViewDetached is called on the previous view, so we must have a
* unique dump tag per instance of this class
* @return a unique tag for this instance of this class
*/
private String getDumpTag() {
return getTag() + " (" + this + ")";
}
@Override