Do not use surface crop as touchable region in standard task

This fixes a refactoring error introduced by commit 3213c96.
This change restores the original logic that if a window is in a
task which should crop touchable region by root task, then just
set the root task surface but not replace the region directly.
Otherwise the touchable region of a sub window may occupy the
entire screen.

Bug: 172522375
Test: WindowStateTests#testUpdateInputWindowHandle
      LoginActivityTest#testAutofillTapOutside
Change-Id: I771b44515c6f70ae3713d3b69658497782dde92c
This commit is contained in:
Riddle Hsu
2020-11-05 19:02:04 +08:00
parent 355c78fcfd
commit 1e4597408e
3 changed files with 6 additions and 8 deletions

View File

@@ -326,11 +326,12 @@ final class InputMonitor {
// the surface hierarchy.
// TODO(b/168252846): we have some issues with modal-windows, so we need to cross
// that bridge now that we organize full-screen Tasks.
inputWindowHandle.replaceTouchableRegionWithCrop(null /* Use this surfaces crop */);
inputWindowHandle.setTouchableRegionCrop(null /* Use this surfaces crop */);
inputWindowHandle.setReplaceTouchableRegionWithCrop(true);
useSurfaceCrop = true;
} else if (task.cropWindowsToStackBounds() && !w.inFreeformWindowingMode()) {
inputWindowHandle.replaceTouchableRegionWithCrop(
task.getRootTask().getSurfaceControl());
inputWindowHandle.setTouchableRegionCrop(task.getRootTask().getSurfaceControl());
inputWindowHandle.setReplaceTouchableRegionWithCrop(false);
useSurfaceCrop = true;
}
}

View File

@@ -255,11 +255,6 @@ class InputWindowHandleWrapper {
mChanged = true;
}
void replaceTouchableRegionWithCrop(@Nullable SurfaceControl bounds) {
setTouchableRegionCrop(bounds);
setReplaceTouchableRegionWithCrop(true);
}
void setTouchableRegionCrop(@Nullable SurfaceControl bounds) {
if (mHandle.touchableRegionSurfaceControl.get() == bounds) {
return;

View File

@@ -694,6 +694,8 @@ public class WindowStateTests extends WindowTestsBase {
mDisplayContent.getInputMonitor().populateInputWindowHandle(handleWrapper, win);
assertTrue(handleWrapper.isChanged());
// The window of standard resizable task should not use surface crop as touchable region.
assertFalse(handle.replaceTouchableRegionWithCrop);
assertEquals(inputChannelToken, handle.token);
assertEquals(win.mActivityRecord.getInputApplicationHandle(false /* update */),
handle.inputApplicationHandle);