Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove onUhandledInputEvent API.

Browse Source 
This callback was never used by WebView and anyone that overrides it
is going to just be broken since we never actually call into it from
the method that WebView does call. Furthermore, the WebView team has
decided that the API has too many complications to ever implement,
the most notable of which is that MotionEvents tend to come in
streams that would need to be buffered in order to detect the event
before it can be determined whether they were handled or not which
means that any uses of the API are inevitably going to be janky
experiences.

Bug: 14279909
Change-Id: I068601ce947bccacabfe55b86b06005449b65bcf
This commit is contained in:
Michael Wright
2016-04-27 13:07:18 -04:00
parent 8891ae1f7f
commit 1ad3955a60
7 changed files with 28 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
api/current.txt
View File

@@ -45774,8 +45774,7 @@ package android.webkit {
method public void onReceivedSslError(android.webkit.WebView, android.webkit.SslErrorHandler, android.net.http.SslError);
method public void onScaleChanged(android.webkit.WebView, float, float);
method public deprecated void onTooManyRedirects(android.webkit.WebView, android.os.Message, android.os.Message);
method public void onUnhandledInputEvent(android.webkit.WebView, android.view.InputEvent);
method public deprecated void onUnhandledKeyEvent(android.webkit.WebView, android.view.KeyEvent);
method public void onUnhandledKeyEvent(android.webkit.WebView, android.view.KeyEvent);
method public deprecated android.webkit.WebResourceResponse shouldInterceptRequest(android.webkit.WebView, java.lang.String);
method public android.webkit.WebResourceResponse shouldInterceptRequest(android.webkit.WebView, android.webkit.WebResourceRequest);
method public boolean shouldOverrideKeyEvent(android.webkit.WebView, android.view.KeyEvent);

8
api/removed.txt
View File

@@ -427,6 +427,14 @@ package android.view {
}
package android.webkit {
public class WebViewClient {
method public void onUnhandledInputEvent(android.webkit.WebView, android.view.InputEvent);
}
}
package android.widget {
public class TextView extends android.view.View implements android.view.ViewTreeObserver.OnPreDrawListener {

3
api/system-current.txt
View File

@@ -48853,8 +48853,7 @@ package android.webkit {
method public void onReceivedSslError(android.webkit.WebView, android.webkit.SslErrorHandler, android.net.http.SslError);
method public void onScaleChanged(android.webkit.WebView, float, float);
method public deprecated void onTooManyRedirects(android.webkit.WebView, android.os.Message, android.os.Message);
method public void onUnhandledInputEvent(android.webkit.WebView, android.view.InputEvent);
method public deprecated void onUnhandledKeyEvent(android.webkit.WebView, android.view.KeyEvent);
method public void onUnhandledKeyEvent(android.webkit.WebView, android.view.KeyEvent);
method public deprecated android.webkit.WebResourceResponse shouldInterceptRequest(android.webkit.WebView, java.lang.String);
method public android.webkit.WebResourceResponse shouldInterceptRequest(android.webkit.WebView, android.webkit.WebResourceRequest);
method public boolean shouldOverrideKeyEvent(android.webkit.WebView, android.view.KeyEvent);

8
api/system-removed.txt
View File

@@ -425,6 +425,14 @@ package android.view {
}
package android.webkit {
public class WebViewClient {
method public void onUnhandledInputEvent(android.webkit.WebView, android.view.InputEvent);
}
}
package android.widget {
public class TextView extends android.view.View implements android.view.ViewTreeObserver.OnPreDrawListener {

3
api/test-current.txt
View File

@@ -45851,8 +45851,7 @@ package android.webkit {
method public void onReceivedSslError(android.webkit.WebView, android.webkit.SslErrorHandler, android.net.http.SslError);
method public void onScaleChanged(android.webkit.WebView, float, float);
method public deprecated void onTooManyRedirects(android.webkit.WebView, android.os.Message, android.os.Message);
method public void onUnhandledInputEvent(android.webkit.WebView, android.view.InputEvent);
method public deprecated void onUnhandledKeyEvent(android.webkit.WebView, android.view.KeyEvent);
method public void onUnhandledKeyEvent(android.webkit.WebView, android.view.KeyEvent);
method public deprecated android.webkit.WebResourceResponse shouldInterceptRequest(android.webkit.WebView, java.lang.String);
method public android.webkit.WebResourceResponse shouldInterceptRequest(android.webkit.WebView, android.webkit.WebResourceRequest);
method public boolean shouldOverrideKeyEvent(android.webkit.WebView, android.view.KeyEvent);

8
api/test-removed.txt
View File

@@ -427,6 +427,14 @@ package android.view {
}
package android.webkit {
public class WebViewClient {
method public void onUnhandledInputEvent(android.webkit.WebView, android.view.InputEvent);
}
}
package android.widget {
public class TextView extends android.view.View implements android.view.ViewTreeObserver.OnPreDrawListener {

3
core/java/android/webkit/WebViewClient.java
View File

@@ -403,9 +403,7 @@ public class WebViewClient {
*
* @param view The WebView that is initiating the callback.
* @param event The key event.
* @deprecated This method is subsumed by the more generic onUnhandledInputEvent.
*/
@Deprecated
public void onUnhandledKeyEvent(WebView view, KeyEvent event) {
onUnhandledInputEventInternal(view, event);
}
@@ -427,6 +425,7 @@ public class WebViewClient {
*
* @param view The WebView that is initiating the callback.
* @param event The input event.
* @removed
*/
public void onUnhandledInputEvent(WebView view, InputEvent event) {
if (event instanceof KeyEvent) {