Media - Fix old players being left around

In addressing sorting, the oldKey was removed but it prevented the
actual player view from being removed. Let the downstream code handle
oldKey -> key migration during resumption scenarios

Fixes: 161031927
Test: atest MediaPlayerDataTest
Change-Id: I937a2732615225235bf1103a2bba0170d3e0b905
This commit is contained in:
Matt Pietal
2020-08-20 11:17:05 -04:00
parent 9b93699911
commit 183b40794e

View File

@@ -172,7 +172,6 @@ class MediaCarouselController @Inject constructor(
// This view is inactive, let's remove this! This happens e.g when dismissing /
// timing out a view. We still have the data around because resumption could
// be on, but we should save the resources and release this.
oldKey?.let { MediaPlayerData.removeMediaPlayer(it) }
onMediaDataRemoved(key)
} else {
addOrUpdatePlayer(key, oldKey, data)