Launch UserSwitchDialog using the expandable
The old `UserSwitchDialogController` class would utilize the `Expandable`, and had the dialog launch itself by creating a `DialogLaunchAnimator.Controller` from the expandable. This CL threads the expandable through to the UserSwitchDialogCoordinator so it can do something similar. Test: UserInteractorTest; manual Bug: 260874319 Change-Id: I86e7df6b8aaa1dccc0cb951c491fd8c6b30294e1
This commit is contained in:
@@ -36,6 +36,7 @@ import com.android.systemui.plugins.FalsingManager
|
||||
import com.android.systemui.qs.QSUserSwitcherEvent
|
||||
import com.android.systemui.qs.tiles.UserDetailView
|
||||
import com.android.systemui.statusbar.phone.SystemUIDialog
|
||||
import com.android.systemui.user.ui.dialog.DialogShowerImpl
|
||||
import javax.inject.Inject
|
||||
import javax.inject.Provider
|
||||
|
||||
@@ -130,19 +131,6 @@ class UserSwitchDialogController @VisibleForTesting constructor(
|
||||
}
|
||||
}
|
||||
|
||||
private class DialogShowerImpl(
|
||||
private val animateFrom: Dialog,
|
||||
private val dialogLaunchAnimator: DialogLaunchAnimator
|
||||
) : DialogInterface by animateFrom, DialogShower {
|
||||
override fun showDialog(dialog: Dialog, cuj: DialogCuj) {
|
||||
dialogLaunchAnimator.showFromDialog(
|
||||
dialog,
|
||||
animateFrom = animateFrom,
|
||||
cuj
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
interface DialogShower : DialogInterface {
|
||||
fun showDialog(dialog: Dialog, cuj: DialogCuj)
|
||||
}
|
||||
|
||||
@@ -493,7 +493,7 @@ constructor(
|
||||
|
||||
fun showUserSwitcher(context: Context, expandable: Expandable) {
|
||||
if (!featureFlags.isEnabled(Flags.FULL_SCREEN_USER_SWITCHER)) {
|
||||
showDialog(ShowDialogRequestModel.ShowUserSwitcherDialog)
|
||||
showDialog(ShowDialogRequestModel.ShowUserSwitcherDialog(expandable))
|
||||
return
|
||||
}
|
||||
|
||||
|
||||
@@ -18,11 +18,13 @@
|
||||
package com.android.systemui.user.domain.model
|
||||
|
||||
import android.os.UserHandle
|
||||
import com.android.systemui.animation.Expandable
|
||||
import com.android.systemui.qs.user.UserSwitchDialogController
|
||||
|
||||
/** Encapsulates a request to show a dialog. */
|
||||
sealed class ShowDialogRequestModel(
|
||||
open val dialogShower: UserSwitchDialogController.DialogShower? = null,
|
||||
open val expandable: Expandable? = null,
|
||||
) {
|
||||
data class ShowAddUserDialog(
|
||||
val userHandle: UserHandle,
|
||||
@@ -45,5 +47,7 @@ sealed class ShowDialogRequestModel(
|
||||
) : ShowDialogRequestModel(dialogShower)
|
||||
|
||||
/** Show the user switcher dialog */
|
||||
object ShowUserSwitcherDialog : ShowDialogRequestModel()
|
||||
data class ShowUserSwitcherDialog(
|
||||
override val expandable: Expandable?,
|
||||
) : ShowDialogRequestModel()
|
||||
}
|
||||
|
||||
@@ -0,0 +1,33 @@
|
||||
/*
|
||||
* Copyright (C) 2022 The Android Open Source Project
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package com.android.systemui.user.ui.dialog
|
||||
|
||||
import android.app.Dialog
|
||||
import android.content.DialogInterface
|
||||
import com.android.systemui.animation.DialogCuj
|
||||
import com.android.systemui.animation.DialogLaunchAnimator
|
||||
import com.android.systemui.qs.user.UserSwitchDialogController.DialogShower
|
||||
|
||||
/** Extracted from [UserSwitchDialogController] */
|
||||
class DialogShowerImpl(
|
||||
private val animateFrom: Dialog,
|
||||
private val dialogLaunchAnimator: DialogLaunchAnimator,
|
||||
) : DialogInterface by animateFrom, DialogShower {
|
||||
override fun showDialog(dialog: Dialog, cuj: DialogCuj) {
|
||||
dialogLaunchAnimator.showFromDialog(dialog, animateFrom = animateFrom, cuj)
|
||||
}
|
||||
}
|
||||
@@ -60,6 +60,7 @@ class UserSwitchDialog(
|
||||
setView(gridFrame)
|
||||
|
||||
adapter.linkToViewGroup(gridFrame.findViewById(R.id.grid))
|
||||
adapter.injectDialogShower(DialogShowerImpl(this, dialogLaunchAnimator))
|
||||
}
|
||||
|
||||
companion object {
|
||||
|
||||
@@ -133,7 +133,10 @@ constructor(
|
||||
}
|
||||
currentDialog = dialog
|
||||
|
||||
if (request.dialogShower != null && dialogCuj != null) {
|
||||
val controller = request.expandable?.dialogLaunchController(dialogCuj)
|
||||
if (controller != null) {
|
||||
dialogLaunchAnimator.get().show(dialog, controller)
|
||||
} else if (request.dialogShower != null && dialogCuj != null) {
|
||||
request.dialogShower?.showDialog(dialog, dialogCuj)
|
||||
} else {
|
||||
dialog.show()
|
||||
|
||||
@@ -813,7 +813,8 @@ class UserInteractorTest : SysuiTestCase() {
|
||||
val job = underTest.dialogShowRequests.onEach { dialogRequest = it }.launchIn(this)
|
||||
|
||||
// Dialog is shown.
|
||||
assertThat(dialogRequest).isEqualTo(ShowDialogRequestModel.ShowUserSwitcherDialog)
|
||||
assertThat(dialogRequest)
|
||||
.isEqualTo(ShowDialogRequestModel.ShowUserSwitcherDialog(expandable))
|
||||
|
||||
underTest.onDialogShown()
|
||||
assertThat(dialogRequest).isNull()
|
||||
|
||||
Reference in New Issue
Block a user