Merge changes 222,223,227

* changes:
  update onCreate method to work around InstrumentationTestRunner limitation.
  Removing unused StreamPipe class, also stripping some white spaces
  * Update the way that run_page_cycler.py detectes instrumentation failures. * Use Debug.getMemoryInfo to collect memory information in LoadTestAutoTest.
This commit is contained in:
Android (Google) Code Review
2009-04-16 11:12:33 -07:00
3 changed files with 55 additions and 59 deletions

View File

@@ -59,7 +59,8 @@ def main(options, args):
run_load_test_cmd = run_load_test_cmd_prefix + " -e class com.android.dumprendertree.LoadTestsAutoTest#runTest -e path \"" + path + "\" -e timeout " + timeout_ms + run_load_test_cmd_postfix
(adb_output, adb_error) = subprocess.Popen(run_load_test_cmd, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE).communicate()
if adb_output.find('INSTRUMENTATION_FAILED') != -1:
if adb_output.find('INSTRUMENTATION_FAILED') != -1 or \
adb_output.find('Process crashed.') != -1:
logging.error("Error happened : " + adb_output)
sys.exit(1)

View File

@@ -51,7 +51,6 @@ public class LayoutTestsAutoRunner extends InstrumentationTestRunner {
@Override
public void onCreate(Bundle icicle) {
super.onCreate(icicle);
this.mTestPath = (String) icicle.get("path");
String timeout_str = (String) icicle.get("timeout");
if (timeout_str != null) {
@@ -64,6 +63,7 @@ public class LayoutTestsAutoRunner extends InstrumentationTestRunner {
String r = (String)icicle.get("rebaseline");
this.mRebaseline = (r != null && r.toLowerCase().equals("true"));
super.onCreate(icicle);
}
public String mTestPath = null;

View File

@@ -16,52 +16,28 @@
package com.android.dumprendertree;
import android.app.Activity;
import android.app.Instrumentation;
import android.app.Instrumentation.ActivityMonitor;
import android.content.Intent;
import android.util.Log;
import android.os.Bundle;
import android.os.Debug;
import android.os.Debug.MemoryInfo;
import android.test.ActivityInstrumentationTestCase2;
import com.android.dumprendertree.TestShellActivity;
import com.android.dumprendertree.TestShellCallback;
import java.io.InputStream;
import java.io.OutputStream;
import java.io.FileOutputStream;
import java.io.IOException;
class StreamPipe extends Thread {
InputStream in;
OutputStream out;
StreamPipe(InputStream in, OutputStream out) {
this.in = in;
this.out = out;
}
public void run() {
try {
byte[] buf = new byte[1024];
int nofb = this.in.read(buf);
while (nofb != -1) {
this.out.write(buf, 0, nofb);
nofb = this.in.read(buf);
}
} catch (IOException e) {
e.printStackTrace();
}
}
}
import java.io.PrintStream;
public class LoadTestsAutoTest extends ActivityInstrumentationTestCase2<TestShellActivity> {
private final static String LOGTAG = "LoadTest";
private final static String LOAD_TEST_RESULT = "/sdcard/load_test_result.txt";
public LoadTestsAutoTest() {
super("com.android.dumprendertree", TestShellActivity.class);
}
@@ -74,7 +50,7 @@ public class LoadTestsAutoTest extends ActivityInstrumentationTestCase2<TestShel
bundle.putBoolean(file, result);
inst.sendStatus(0, bundle);
}
// Invokes running of layout tests
// and waits till it has finished running.
public void runTest() {
@@ -84,7 +60,7 @@ public class LoadTestsAutoTest extends ActivityInstrumentationTestCase2<TestShel
Log.e(LOGTAG, "No test specified");
return;
}
TestShellActivity activity = (TestShellActivity) getActivity();
// Run tests
@@ -92,38 +68,57 @@ public class LoadTestsAutoTest extends ActivityInstrumentationTestCase2<TestShel
// TODO(fqian): let am instrumentation pass in the command line, currently
// am instrument does not allow spaces in the command.
runPostShellCommand("/system/bin/dumpsys meminfo");
dumpMemoryInfo();
// Kill activity
activity.finish();
}
private void runPostShellCommand(String cmd) {
if (cmd == null || cmd.length() == 0)
return;
private void dumpMemoryInfo() {
try {
// Call dumpsys meminfo
Process proc = Runtime.getRuntime().exec(cmd);
// Append output to LOAD_TEST_RESULT
InputStream input = proc.getInputStream();
InputStream error = proc.getErrorStream();
FileOutputStream out = new FileOutputStream(LOAD_TEST_RESULT, true);
Log.v(LOGTAG, "Dumping memory information.");
StreamPipe p_in = new StreamPipe(input, out);
StreamPipe p_err = new StreamPipe(error, System.err);
p_in.start();
p_err.start();
proc.waitFor();
FileOutputStream out = new FileOutputStream(LOAD_TEST_RESULT, true);
PrintStream ps = new PrintStream(out);
MemoryInfo mi = new MemoryInfo();
Debug.getMemoryInfo(mi);
//try to fake the dumpsys format
//this will eventually be changed to XML
String format = "%15s:%9d%9d%9d%9d";
String pss =
String.format(format, "(Pss)",
mi.nativePss, mi.dalvikPss, mi.otherPss,
mi.nativePss + mi.dalvikPss + mi.otherPss);
String sd =
String.format(format, "(shared dirty)",
mi.nativeSharedDirty, mi.dalvikSharedDirty, mi.otherSharedDirty,
mi.nativeSharedDirty + mi.dalvikSharedDirty + mi.otherSharedDirty);
String pd =
String.format(format, "(priv dirty)",
mi.nativePrivateDirty, mi.dalvikPrivateDirty, mi.otherPrivateDirty,
mi.nativePrivateDirty + mi.dalvikPrivateDirty + mi.otherPrivateDirty);
ps.print("\n\n\n");
ps.println("** MEMINFO in pid 0 [com.android.dumprendertree] **");
ps.println(" native dalvik other total");
ps.println(" size: 12060 5255 N/A 17315");
ps.println(" allocated: 12060 5255 N/A 17315");
ps.println(" free: 12060 5255 N/A 17315");
ps.println(pss);
ps.println(sd);
ps.println(pd);
ps.print("\n\n\n");
ps.flush();
ps.close();
out.flush();
out.close();
} catch (IOException e) {
Log.e(LOGTAG, e.getMessage());
} catch (InterruptedException e) {
Log.e(LOGTAG, e.getMessage());
}
}
}
// A convenient method to be called by another activity.
private void runTestAndWaitUntilDone(TestShellActivity activity, String url, int timeout) {
activity.setCallback(new TestShellCallback() {
@@ -131,9 +126,9 @@ public class LoadTestsAutoTest extends ActivityInstrumentationTestCase2<TestShel
synchronized (LoadTestsAutoTest.this) {
LoadTestsAutoTest.this.notifyAll();
}
}
}
});
Intent intent = new Intent(Intent.ACTION_VIEW);
intent.setClass(activity, TestShellActivity.class);
intent.addFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP);
@@ -141,12 +136,12 @@ public class LoadTestsAutoTest extends ActivityInstrumentationTestCase2<TestShel
intent.putExtra(TestShellActivity.TIMEOUT_IN_MILLIS, timeout);
intent.putExtra(TestShellActivity.RESULT_FILE, LOAD_TEST_RESULT);
activity.startActivity(intent);
// Wait until done.
synchronized (this) {
try {
this.wait();
} catch (InterruptedException e) { }
}
}
}
}