Fixed footer jump animation on QS Container

This bug was caused by a conditional check where the bottom padding of
the footer icons is set to 0 when in QS Edit mode.

Fixes: 233290729
Test: atest NotificationQSContainerControllerTest
Change-Id: I1c7bdc5939d6f15749b6eed268a0bc8035a4eea0
This commit is contained in:
Rasheed Lewis
2023-05-08 02:14:32 +00:00
parent 8bcb06a146
commit 15b9c75fea
2 changed files with 1 additions and 20 deletions

View File

@@ -216,7 +216,7 @@ class NotificationsQSContainerController @Inject constructor(
containerPadding = 0
stackScrollMargin = bottomStableInsets + notificationsBottomMargin
}
val qsContainerPadding = if (!(isQSCustomizing || isQSDetailShowing)) {
val qsContainerPadding = if (!isQSDetailShowing) {
// We also want this padding in the bottom in these cases
if (splitShadeEnabled) {
stackScrollMargin - scrimShadeBottomMargin - footerActionsOffset

View File

@@ -228,25 +228,6 @@ class NotificationQSContainerControllerTest : SysuiTestCase() {
expectedQsPadding = STABLE_INSET_BOTTOM)
}
@Test
fun testCustomizingInSinglePaneShade() {
disableSplitShade()
controller.setCustomizerShowing(true)
// always sets spacings to 0
given(taskbarVisible = false,
navigationMode = GESTURES_NAVIGATION,
insets = windowInsets().withStableBottom())
then(expectedContainerPadding = 0,
expectedNotificationsMargin = 0)
given(taskbarVisible = false,
navigationMode = BUTTONS_NAVIGATION,
insets = emptyInsets())
then(expectedContainerPadding = 0,
expectedNotificationsMargin = 0)
}
@Test
fun testDetailShowingInSinglePaneShade() {
disableSplitShade()