Silence a memory leak warning from the static analyzer

The analyzer assumes that the given `put` operation may fail. This
shouldn't be the case, so mark it with a LOG_ALWAYS_FATAL_IF. Doing so
silences a warning about potential memory leaks originating from
TessellationCache::getRoundRect.

Bug: 27101951
Test: mma. Warning is gone.
Change-Id: I3adeacd6c2c9c03caecd989e2a1267c51e8ef905
This commit is contained in:
George Burgess IV
2017-07-25 14:22:07 -07:00
parent d00de318f9
commit 13d7ddac23

View File

@@ -416,7 +416,9 @@ TessellationCache::Buffer* TessellationCache::getOrCreateBuffer(
mProcessor = new TessellationProcessor(Caches::getInstance());
}
mProcessor->add(task);
mCache.put(entry, buffer);
bool inserted = mCache.put(entry, buffer);
// Note to the static analyzer that this insert should always succeed.
LOG_ALWAYS_FATAL_IF(!inserted, "buffers shouldn't spontaneously appear in the cache");
}
return buffer;
}