Increase the GroupCoalescer's minimum linger duration.

Bug: 213368402
Test: manual testing, watching logs
Change-Id: Iaf7926fb385a94d46453928eb7cf5ed5b684b8b7
This commit is contained in:
Jeff DeCew
2022-01-19 15:28:08 +00:00
parent 53aa02dd89
commit 134550b544
2 changed files with 7 additions and 4 deletions

View File

@@ -260,7 +260,8 @@ public class GroupCoalescer implements Dumpable {
}
events.sort(mEventComparator);
mLogger.logEmitBatch(batch.mGroupKey);
long batchAge = mClock.uptimeMillis() - batch.mCreatedTimestamp;
mLogger.logEmitBatch(batch.mGroupKey, batch.mMembers.size(), batchAge);
mHandler.onNotificationBatchPosted(events);
}
@@ -337,6 +338,6 @@ public class GroupCoalescer implements Dumpable {
void onNotificationBatchPosted(List<CoalescedEvent> events);
}
private static final int MIN_GROUP_LINGER_DURATION = 50;
private static final int MIN_GROUP_LINGER_DURATION = 200;
private static final int MAX_GROUP_LINGER_DURATION = 500;
}

View File

@@ -32,11 +32,13 @@ class GroupCoalescerLogger @Inject constructor(
})
}
fun logEmitBatch(groupKey: String) {
fun logEmitBatch(groupKey: String, batchSize: Int, batchAgeMs: Long) {
buffer.log(TAG, LogLevel.DEBUG, {
str1 = groupKey
int1 = batchSize
long1 = batchAgeMs
}, {
"Emitting event batch for group $str1"
"Emitting batch for group $str1 size=$int1 age=${long1}ms"
})
}