Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removing the DEBUG flag check while logging traces

Browse Source 
This CL has 2 changes
1. Not checking the DEBUG flag when logging the traces
2. Changing the utility used to log the trace to Trace.traceBegin(...)
   method. This is to log the traces in the SystemServer context, aginst
   the old method which logged the traces in the app context

Bug: 249306380
Test: Manual
Change-Id: Id32799cd9a11d984ae4bf9d69f59167b1636068b
This commit is contained in:
Rupesh Bansal
2022-09-27 17:34:51 +00:00
parent b326bba8a4
commit 0e0eb14d5d
3 changed files with 9 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
services/core/java/com/android/server/display/DisplayDeviceRepository.java
View File

@@ -167,7 +167,8 @@ class DisplayDeviceRepository implements DisplayAdapter.Listener {
return;
}
if (DEBUG) {
Trace.beginSection("handleDisplayDeviceChanged");
Trace.traceBegin(Trace.TRACE_TAG_POWER,
"handleDisplayDeviceChanged");
}
int diff = device.mDebugLastLoggedDeviceInfo.diff(info);
if (diff == DisplayDeviceInfo.DIFF_STATE) {
@@ -189,7 +190,7 @@ class DisplayDeviceRepository implements DisplayAdapter.Listener {
device.applyPendingDisplayDeviceInfoChangesLocked();
sendEventLocked(device, DISPLAY_DEVICE_EVENT_CHANGED);
if (DEBUG) {
Trace.endSection();
Trace.traceEnd(Trace.TRACE_TAG_POWER);
}
}
}

9
services/core/java/com/android/server/display/DisplayPowerController.java
View File

@@ -1172,13 +1172,10 @@ final class DisplayPowerController implements AutomaticBrightnessController.Call
}
private void updatePowerState() {
if (DEBUG) {
Trace.beginSection("DisplayPowerController#updatePowerState");
}
Trace.traceBegin(Trace.TRACE_TAG_POWER,
"DisplayPowerController#updatePowerState");
updatePowerStateInternal();
if (DEBUG) {
Trace.endSection();
}
Trace.traceEnd(Trace.TRACE_TAG_POWER);
}
private void updatePowerStateInternal() {

9
services/core/java/com/android/server/display/DisplayPowerController2.java
View File

@@ -1172,13 +1172,10 @@ final class DisplayPowerController2 implements AutomaticBrightnessController.Cal
}
private void updatePowerState() {
if (DEBUG) {
Trace.beginSection("DisplayPowerController#updatePowerState");
}
Trace.traceBegin(Trace.TRACE_TAG_POWER,
"DisplayPowerController#updatePowerState");
updatePowerStateInternal();
if (DEBUG) {
Trace.endSection();
}
Trace.traceEnd(Trace.TRACE_TAG_POWER);
}
private void updatePowerStateInternal() {