Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add dropbox entries as files to dumpstate ZIP.

Browse Source 
Since each dropbox entry is already stored as a file on disk, include
them as-is into the dumpstate ZIP file.

The dumpsys output has already included truncated versions of all
dropbox entries for many years, and adding them as separate files
inside the dumpstate ZIP will speed up debugging and issue triage.

Bug: 267673062
Test: manual
Change-Id: I5a45e39012cebc5fea1e2d0be3146519de7cafd8
This commit is contained in:
Jeff Sharkey
2023-02-06 14:26:05 -07:00
parent bff6b3b979
commit 0d70573193
1 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
services/core/java/com/android/server/DropBoxManagerService.java
View File

@@ -693,7 +693,7 @@ public final class DropBoxManagerService extends SystemService {
out.append(file.getPath()).append("\n");
}
if ((entry.flags & DropBoxManager.IS_TEXT) != 0 && (doPrint || !doFile)) {
if ((entry.flags & DropBoxManager.IS_TEXT) != 0 && doPrint) {
DropBoxManager.Entry dbe = null;
InputStreamReader isr = null;
try {
@@ -717,17 +717,6 @@ public final class DropBoxManagerService extends SystemService {
}
}
if (!newline) out.append("\n");
} else {
String text = dbe.getText(70);
out.append(" ");
if (text == null) {
out.append("[null]");
} else {
boolean truncated = (text.length() == 70);
out.append(text.trim().replace('\n', '/'));
if (truncated) out.append(" ...");
}
out.append("\n");
}
} catch (IOException e) {
out.append("*** ").append(e.toString()).append("\n");