Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't convert conversation senders to the wrong enum

Browse Source 
Bug: 276950971
Test: ZenModeConfigTest
Change-Id: I7efb90982dbc8102552abd8244c0ec06fff6601e
This commit is contained in:
Yuri Lin
2023-04-04 16:00:29 -04:00
parent 245b979bd0
commit 0ce93167c8
2 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/java/android/service/notification/ZenModeConfig.java
View File

@@ -1008,9 +1008,8 @@ public class ZenModeConfig implements Parcelable {
.allowAlarms(allowAlarms)
.allowMedia(allowMedia)
.allowSystem(allowSystem)
.allowConversations(allowConversations
? ZenModeConfig.getZenPolicySenders(allowConversationsFrom)
: ZenPolicy.PEOPLE_TYPE_NONE);
.allowConversations(allowConversations ? allowConversationsFrom
: ZenPolicy.CONVERSATION_SENDERS_NONE);
if (suppressedVisualEffects == 0) {
builder.showAllVisualEffects();
} else {

12
services/tests/uiservicestests/src/com/android/server/notification/ZenModeConfigTest.java
View File

@@ -120,12 +120,20 @@ public class ZenModeConfigTest extends UiServiceTestCase {
.showLights(false)
.showBadges(false)
.showInAmbientDisplay(false)
.allowCalls(ZenPolicy.PEOPLE_TYPE_CONTACTS)
.allowMessages(ZenPolicy.PEOPLE_TYPE_STARRED)
.allowConversations(ZenPolicy.CONVERSATION_SENDERS_NONE)
.build();
ZenModeConfig config = getMutedAllConfig();
config.allowAlarms = true;
config.allowReminders = true;
config.allowEvents = true;
config.allowCalls = true;
config.allowCallsFrom = Policy.PRIORITY_SENDERS_CONTACTS;
config.allowMessages = true;
config.allowMessagesFrom = Policy.PRIORITY_SENDERS_STARRED;
config.allowConversations = false;
config.suppressedVisualEffects |= Policy.SUPPRESSED_EFFECT_BADGE;
config.suppressedVisualEffects |= Policy.SUPPRESSED_EFFECT_LIGHTS;
config.suppressedVisualEffects |= Policy.SUPPRESSED_EFFECT_AMBIENT;
@@ -138,6 +146,10 @@ public class ZenModeConfigTest extends UiServiceTestCase {
assertEquals(expected.getPriorityCategoryEvents(), actual.getPriorityCategoryEvents());
assertEquals(expected.getVisualEffectLights(), actual.getVisualEffectLights());
assertEquals(expected.getVisualEffectAmbient(), actual.getVisualEffectAmbient());
assertEquals(expected.getPriorityConversationSenders(),
actual.getPriorityConversationSenders());
assertEquals(expected.getPriorityCallSenders(), actual.getPriorityCallSenders());
assertEquals(expected.getPriorityMessageSenders(), actual.getPriorityMessageSenders());
}
@Test